search

cpp-lln-lab / CPP_PTB

a set of function to make it easier to create behavioral, EEG, fMRI experiment with psychtoolbox
https://cpp-ptb.readthedocs.io/en/latest/index.html#
MIT License
12 stars 13 forks source link

EyeTracker - add switch case to record a 'message' (tag) in the output #106

Closed marcobarilari closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #106 into dev will decrease coverage by 0.08%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #106      +/-   ##
==========================================
- Coverage   25.81%   25.73%   -0.09%     
==========================================
  Files          44       44              
  Lines         643      645       +2     
==========================================
  Hits          166      166              
- Misses        477      479       +2
Flag Coverage Δ
#unittests 25.73% <0.00%> (-0.09%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/eyeTracker.m 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cfa1f86...c93313f. Read the comment docs.

marcobarilari commented 3 years ago

resolves #84

marcobarilari commented 3 years ago

I think those few lines will do what we need to tag the ET output

marcobarilari commented 3 years ago

I guess that Travis is complaining because of the new release of miss_hit, @Remi-Gau let me know how you want to manage this at the repo level.

Easily, I can do it in this pr but we lose a bit of of congruety between pr title and what it really does OR I (or anyonelse) can do it in a separate branch of dev and then I rebase this pr with dev and we merge this one with only the changes regarding the ET.

LMK

Remi-Gau commented 3 years ago

you're right let's focus on the content of this PR. we'll fix the style in another one. or maybe just fix the style only of the files you have changed already.

Remi-Gau commented 3 years ago

I think miss_hit can do this

mh_style filename.m --fix
marcobarilari commented 3 years ago

done already 🤓

if I remember well, if travis fails merge is blocked, am I right?

Remi-Gau commented 3 years ago

nope : you as an admin can override it as long as it is on the dev branch

Remi-Gau commented 3 years ago

let me rephrase that: NOW that have made you admin and not "just" maintainer you CAN do that. :-)

Remi-Gau commented 3 years ago

OK I will review this first. Because the code styling can be automated more easily.

Remi-Gau commented 3 years ago

merging and then will check the next PR