cpp-lln-lab / CPP_PTB

a set of function to make it easier to create behavioral, EEG, fMRI experiment with psychtoolbox
https://cpp-ptb.readthedocs.io/en/latest/index.html#
MIT License
12 stars 13 forks source link

waitForTrigerr, from KbPressWait to KbCheck #116

Closed marcobarilari closed 3 years ago

marcobarilari commented 3 years ago

Changed KbPressWait to KbCheck so that triggerino can be used with this.

I did not add any check for all key released (the classic while KbCheck; end) because it is useless since the func has a pauseBetweenTriggers (either 0.5 secs or cfg.mri.repetitionTime / 2). With the check it has a weird behavior, I don't know why.

The 'downside' of that is that if you keep the triggerKey' pressed it will take the triggers at the pace ofpauseBetweenTriggers`, but I think we can live with that.

fix #115

codecov[bot] commented 3 years ago

Codecov Report

Merging #116 into dev will not change coverage. The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #116   +/-   ##
=======================================
  Coverage   29.05%   29.05%           
=======================================
  Files          47       47           
  Lines         702      702           
=======================================
  Hits          204      204           
  Misses        498      498           
Flag Coverage Δ
#unittests 29.05% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/waitForTrigger.m 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 95f750e...dbf563b. Read the comment docs.