cpp-lln-lab / CPP_PTB

a set of function to make it easier to create behavioral, EEG, fMRI experiment with psychtoolbox
https://cpp-ptb.readthedocs.io/en/latest/index.html#
MIT License
12 stars 13 forks source link

Remove Flickering Dots #162

Closed iqrashahzad14 closed 2 years ago

iqrashahzad14 commented 2 years ago

New Dots start at timepoint 0

codecov[bot] commented 2 years ago

Codecov Report

Merging #162 (4a6fe15) into dev (9536de7) will decrease coverage by 0.01%. The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #162      +/-   ##
==========================================
- Coverage   21.57%   21.55%   -0.02%     
==========================================
  Files          55       56       +1     
  Lines         788      798      +10     
==========================================
+ Hits          170      172       +2     
- Misses        618      626       +8     
Flag Coverage Δ
unittests 21.55% <33.33%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/aperture/apertureTexture.m 0.00% <ø> (ø)
src/aperture/eccenLogSpeed.m 0.00% <ø> (ø)
src/aperture/smoothOval.m 0.00% <ø> (ø)
src/aperture/smoothRect.m 0.00% <ø> (ø)
src/dot/decomposeMotion.m 100.00% <ø> (ø)
src/dot/dotMotionSimulation.m 0.00% <ø> (ø)
src/dot/initDots.m 100.00% <ø> (ø)
src/dot/setDotDirection.m 90.00% <ø> (ø)
src/drawFieldOfVIew.m 0.00% <0.00%> (ø)
src/eyeTracker.m 0.00% <ø> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9536de7...4a6fe15. Read the comment docs.

marcobarilari commented 2 years ago

@iqrashahzad14 thank you very much to catch this one, it is very useful (sorry to take over, we might use this patch tomorrow ;) )

marcobarilari commented 2 years ago

tested and working, merging