cpp-lln-lab / bidspm

an SPM centric BIDS app
https://bidspm.readthedocs.io/en/latest/general_information.html
GNU General Public License v3.0
5 stars 13 forks source link

[BUG] Analysis level dataset is not passed on to bidspm function #1249

Closed monique2208 closed 2 months ago

monique2208 commented 2 months ago

Is there an existing issue for this?

Operating system

Operating system version

No response

SPM 12 version

Platform

Platform version

No response

bidspm version

v3.1.0

bidspm branch / commit number

apptainer run --no-mount bind-paths --cleanenv --bindds003717:/bids /home/mdenissen/containers/bidspm_current.sif /bids /bids dataset --action stats --task SESS06 --model /bids/derivatives/models/model-defaultSESS06_smdl.json --preproc_dir /bids/derivatives/bidspm-preproc --space MNI152NLin2009cAsym --skip_validation

Expected Behavior

Run dataset level from command line

BIDS stats model

No response

Current Behavior & Error message

There are no errors, but I am still running subject level:

bidspm('/bids', ...
                         '/bids', ...
                         'subject', ...
                         'action', 'stats', ...
                         'verbosity', 2, ...
                         'space', { 'MNI152NLin2009cAsym' }, ...
                         'fwhm', 6.0, ...
                         'skip_validation', true, ...
                         'preproc_dir', '/bids/derivatives/bidspm-preproc', ...
                         'model_file', '/bids/derivatives/models/model-defaultSESS06_smdl.json');

Anything else?

The command seems ignored explicitly, only the default model action takes the dataset level into account.

https://github.com/cpp-lln-lab/bidspm/blob/a8a61d6a730b0519d14b6fc53da1114b30b64c71/src/bidspm.py#L226

Is this intentional?

github-actions[bot] commented 2 months ago

Thank you for your issue. Give us a little time to review it.

PS. You might want to check the FAQ if you haven't done so already.

This is an automated reply, generated by FAQtory