cpp-lln-lab / bidspm

an SPM centric BIDS app
https://bidspm.readthedocs.io/en/latest/general_information.html
GNU General Public License v3.0
7 stars 14 forks source link

wrong TR is shown in commander window during slice timing #763

Closed yyang1234 closed 2 years ago

yyang1234 commented 2 years ago

Hi, when I run the slicing time during preprocessing, the TR shown in the command window is 3.5s, twice as large as the actual TR (1.75s). It might because that in line 99 of setBatchSTC.m, nbslice is calculated by finding the unique slice time: nbSlices = numel(unique(sliceOrder));

My data used multiband,so half of them had the same slice time as the other half. So nbslice only gets half of the actual slice number.

unique is necessary in case of multi echo.

Remi-Gau commented 2 years ago

This should be fixed.

Will close after one final check and adding comments to explain better why some things are done this way.

Remi-Gau commented 2 years ago

@all-contributors please add @yyang1234 for bug, userTesting

allcontributors[bot] commented 2 years ago

@Remi-Gau

I've put up a pull request to add @yyang1234! :tada: