search

cpp-lln-lab / localizer_visual_motion

MIT License
2 stars 9 forks source link

[INFRA, DOC, REF] Misc #105

Closed Remi-Gau closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #105 (22daf9b) into dev (3cbd375) will increase coverage by 2.47%. The diff coverage is 44.94%.

:exclamation: Current head 22daf9b differs from pull request most recent head 7fcb87f. Consider uploading reports for the commit 7fcb87f to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #105      +/-   ##
==========================================
+ Coverage   41.07%   43.54%   +2.47%     
==========================================
  Files          15       17       +2     
  Lines         224      395     +171     
==========================================
+ Hits           92      172      +80     
- Misses        132      223      +91
Flag Coverage Δ
unittests 43.54% <44.94%> (+2.47%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
subfun/design/expDesign.m 73.33% <ø> (ø)
subfun/doDotMo.m 0.00% <0.00%> (ø)
subfun/postInitializationSetup.m 0.00% <0.00%> (ø)
subfun/visualMotionLocalizer.m 0.00% <0.00%> (ø)
subfun/defaults/checkParameters.m 83.33% <83.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3cbd375...7fcb87f. Read the comment docs.

marcobarilari commented 2 years ago

Very nice, thanks!

So now everything that I would like to "customize" will go as cfg input into main.m before calling the func visualMotionLocalizer(cfg), correct?

Will add everything we need for our case and let's how long it will be.

Another thought I have is that it would be useful, at least for us, to have a main which is transversal to all the experiment we need to run (audio visual mst localizers and main experiment). This implies the the initEnv might have a path-to/initEnv() and that at the end of each run/task we should have a deactivateEnv() in case different experiments point to different version of eg CPP_PTB.