Update "mysql-client" help-wanted/needed

[cyberium]

• I'm interested to update mysql-client, i would need some help tho.

• Here is the current version https://github.com/hunter-packages/mysql-client>

• This package is using already hunterized but its old and may be not hunterzed as it should>

Some interesting links

• Last update -> https://github.com/ruslo/hunter/pull/755
• MySQL package discussion -> https://github.com/ruslo/hunter/issues/750
• Gitter discussion -> https://gitter.im/cpp-pm/community?at=5dfb9b008dfce538b5d43d7a

Main problem:

• Old version on package repository.
• But also cannot be built on: Os Linux osboxes 4.19.0-6-amd64 #1 SMP Debian 4.19.67-2+deb10u2 (2019-11-11) x86_64 GNU/Linux GCC: 8.3.0 (Debian 8.3.0-6) cmake : 3.13.4

Error is :

[ 65%] Building C object mysys/CMakeFiles/mysys.dir/my_lib.c.o
/home/cybermomo/cmangos/hunter/_Base/e998928/688591e/4b09d2b/Build/MySQL-client/Source/mysys/my_lib.c: In function ‘my_dir’:
/home/cybermomo/cmangos/hunter/_Base/e998928/688591e/4b09d2b/Build/MySQL-client/Source/mysys/my_lib.c:127:3: error: ‘readdir_r’ is deprecated [-Werror=deprecated-declarations]
   while (!(READDIR(dirp,(struct dirent*) dirent_tmp,dp)))
   ^~~~~
In file included from /usr/include/features.h:424,
                 from /usr/include/x86_64-linux-gnu/bits/libc-header-start.h:33,
                 from /usr/include/stdio.h:27,
                 from /home/cybermomo/cmangos/hunter/_Base/e998928/688591e/4b09d2b/Build/MySQL-client/Source/include/my_global.h:41,
                 from /home/cybermomo/cmangos/hunter/_Base/e998928/688591e/4b09d2b/Build/MySQL-client/Source/mysys/mysys_priv.h:19,
                 from /home/cybermomo/cmangos/hunter/_Base/e998928/688591e/4b09d2b/Build/MySQL-client/Source/mysys/my_lib.c:19:
/usr/include/dirent.h:189:12: note: declared here
 extern int __REDIRECT (readdir_r,
            ^~~~~~~~~~
cc1: all warnings being treated as errors

• Tested :

  hunter_config(MySQL-client VERSION 6.1.9-p1 CMAKE_ARGS CMAKE_CXX_FLAGS=-Wno-error=deprecated-declarations)

without success (look like the flag is discarded somewhere)

[cyberium]

Oracle decided to not provide directly connector c anymore in the form we use it.

C API (libmysqlclient) is a client library for C development.

For C-language and SQL:

for MySQL 8.0, 5.7, 5.6, 5.5
we recommend MySQL 8.0 C API
For C-language and NoSQL XDevApi DocStore:

for MySQL 8.0 [not applicable to 5.7, 5.6, 5.5]
we recommend MySQL Connector/C++ 8.0
note:  Connector/C++ 8.0 has compatible C headers
C API (libmysqlclient) is included in MySQL 8.0

Linux: The Client Utilities Package is available from the MySQL Community Server download page.
Repos: The Client Utilities Package is available from the Yum, APT, SuSE repositories.
Windows: The Client Utilities Package is available from the Windows Installer.
Previous GA versions are available from MySQL Product Archives.

Online Documentation:

MySQL C API
Please report any bugs or inconsistencies you observe to our Bugs Database.
Thank you for your support!

Latest updated code is 6.1.11 and can be found -> https://downloads.mysql.com/archives/c-c/

Therefore to keep this package updated we have some different options:

• Update to 6.1.11 : update should be easy but that code is from 2017 so it doesn't fit our purpose.
• Switch to cpp connector https://github.com/mysql/mysql-connector-cpp. Its not exactly same as connector c api iam not sure if it replace libmysql api perfectly or need code changes. Major problem to use cpp connector is its not a full source. It have as requirement to have mysql server installed on the system. That make it more hard to hunterize i think. They also maintain 3 different branches, 1.xx, 2.xx and 8.xx. Not sure yet about all differences.
• Take part of the latest mysql server code and clean it to make it lighter and keep only libmysql target. https://github.com/mysql/mysql-server
• Take latest mysql server and hunterize it as it is so we can have MySQL::client and MySQL::server target. Maybe just do a cleanup to make it lighter.

Let me know your thoughts

[bkotzz]

The connector doesn’t seem that useful in hunter if it requires the server to be installed anyway. Updating to 6.1.11 doesn’t seem worthwhile if it doesn’t meet your needs as it doesn’t look like it is maintained. Seems like the last two options would be best.