search

cpp-redis / cpp_redis

C++11 Lightweight Redis client: async, thread-safe, no dependency, pipelining, multi-platform
MIT License
720 stars 199 forks source link

CONTRIBUTING.md testing instructions #12

Closed dgpetrie closed 5 years ago

dgpetrie commented 5 years ago

In CONTRIBUTING.md:

  1. Build the entire library: It referes to tests: ./bin/subscriber ./bin/client

Pardon, my ignorance if I missed something as I am a bit of a cmake newbie. I am not seeing any rules to build these targets.

appkins commented 5 years ago

In the CMake file, there is the following:

if (BUILD_EXAMPLES)
    add_subdirectory(examples)
    # Reset variable to false to ensure tacopie does no build examples
    set(BUILD_EXAMPLES false)
endif (BUILD_EXAMPLES)

Just pass -DBUILD_EXAMPLES=ON as a cmake param to build the examples.

It's worth noting that we can make BUILD_EXAMPLES an option that can be tweaked using the cmake GUI. I'm happy to introduce these changes if the community prefers cache variables.

dgpetrie commented 5 years ago

Thank you for the update on the build instructions. Sorry, if I am missing something, but that still does not produce: ./bin/subscriber ./bin/client

It does produce: bin/cpp_redis_client
bin/cpp_redis_future_client
bin/cpp_redis_kill
bin/cpp_redis_streams_client bin/cpp_redis_consumer
bin/cpp_redis_high_availability_client
bin/cpp_redis_logger
bin/cpp_redis_subscriber