search

cpp-redis / cpp_redis

C++11 Lightweight Redis client: async, thread-safe, no dependency, pipelining, multi-platform
MIT License
713 stars 198 forks source link

xmessage non-virt dtor compile warning. #35

Open KarlBlomquist opened 5 years ago

KarlBlomquist commented 5 years ago

Describe the bug Ok, so not a bug per se, but wondering if this is expected and if so, why not dealt with?

Ubuntu 18.04, clang 7, llvm. Generic make of cpp_redis yields...

warning: destructor called on non-final 'cpp_redis::xmessage' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]

To Reproduce Ubuntu 18.04, pull repo, set env CC CXX to clang, add libc++ into CMakeFile.txt, build per instructions, see Warning.

Expected behavior Error-free build.

Screenshots xmessage-warning

Desktop (please complete the following information):

I added a virtual dtor in xmessage decl 

        class xmessage : public message_type {
    public:
            xmessage();
            virtual ~xmessage() {};

            explicit xmessage(const reply_t &data);

            friend std::ostream &operator<<(std::ostream &os, const xmessage &xm);
    };

and the warning is gone as expected.

Just wondering if this is a known issue and if it was left as-is on purpose?

Thanks.