search

cppad / swift

https://cppad.github.io/swift
0 stars 0 forks source link

Resize Home core value icons #1

Open michulee opened 3 years ago

michulee commented 3 years ago

18d49572f49d37db56ca3fe100274bfdfe64f83f use .svg-inline--fa to directly target icon

when using class={}, icon auto fills the container but can't resize with.core-icons class

michulee commented 3 years ago

This issue is for the core values section on index.js.

When using className, you are able to resize the icon. <FontAwesomeIcon icon={faHandshake} className={clsx("core-icons")}/>

However, when using class, classes don't work and the icon fills its container. This seems to effect only <FontAwesomeIcon />. <FontAwesomeIcon icon={faHandshake} class={clsx()}/>

Should we use className for everything, or should we use only className just for <FontAwesomeIcon />? I made notes in the documentation about class and className.

When it comes to React, you CAN use className instead of class ; there's no functional difference. The reason for this decision was because of the definition of a keyword. Because class is native to JavaScript, you use className for JSX. There doesn't seem to be any functional changes except that the keywords are named differently.

class is a keyword in JavaScript and JSX is an extension of JavaScript. A keyword means that a token has a special meaning in a language syntax.

It also seems that clsx is faster than classnames .

The developers of React were going to make className → class after many requests, but this issue was shelved due to "syntax limitations" (Aug 2020). For legacy purposes, it's best to use class because the team at React are serious about this issue.

Issue has been fixed. 8f230e3b0bcae0af225494c6a591aa10e0a98b2f