search

cppalliance / NuDB

NuDB: A fast key/value insert-only database for SSD drives in C++11
Boost Software License 1.0
384 stars 59 forks source link

[TRIVIAL] Add missing includes #100

Closed ximinez closed 3 months ago

ximinez commented 3 months ago

std::logic_error is defined in <stdexcept>. These files changed in this PR reference it without including that header. In most environments, the definition is included through other headers, but not all. Specifically, I ran into a build error with rippled Windows non-unity builds after some headers were reordered.

See also: https://github.com/XRPLF/rippled/pull/5061

vinniefalco commented 3 months ago

Ed, I've invited you as a maintainer of the repository if you would like to merge this when you feel it is ready to do so. Thanks!

ximinez commented 3 months ago

Fantastic! Thanks, Vinnie. I think it's ready to merge now if there are no objections. I'll push the button Friday morning.