Closed ximinez closed 3 months ago
Ed, I've invited you as a maintainer of the repository if you would like to merge this when you feel it is ready to do so. Thanks!
Fantastic! Thanks, Vinnie. I think it's ready to merge now if there are no objections. I'll push the button Friday morning.
std::logic_error
is defined in<stdexcept>
. These files changed in this PR reference it without including that header. In most environments, the definition is included through other headers, but not all. Specifically, I ran into a build error with rippled Windows non-unity builds after some headers were reordered.See also: https://github.com/XRPLF/rippled/pull/5061