Closed vinniefalco closed 8 years ago
@@ master #28 diff @@
==========================================
Files 26 27 +1
Lines 1720 1719 -1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1604 1639 +35
+ Misses 116 80 -36
Partials 0 0
Powered by Codecov. Last update 64814a4...4bb090c
@vinniefalco: Please cherry-pick 6fe05f2acc8fcef7a841adaec71975ed79154602 to get some improvements for Buffer
, including fixing an incorrect return
in the copy constructor, fixing a bug in the move-assignment operator that could have left the object in an inconsistent state, and ensuring that there is no UB when copy-constructing Buffer
objects or using Buffer operator(void const*, size_t)
.
Update: (Picked and squashed)
:+1:
This needs Scott's bench changes before it can be merged
LGTM :+1:
Odds and ends
Reviewers: @miguelportilla @wilsonianb