cppalliance / NuDB

NuDB: A fast key/value insert-only database for SSD drives in C++11
Boost Software License 1.0
384 stars 59 forks source link

1.0.0-b4 #28

Closed vinniefalco closed 8 years ago

vinniefalco commented 8 years ago

Odds and ends

Reviewers: @miguelportilla @wilsonianb

coveralls commented 8 years ago

Coverage Status

Coverage increased (+2.3%) to 95.533% when pulling 0035a84ee3795168c3a0c9ab69877ed4d48d5fa3 on develop into 64814a4aa58c8cbfee1eec9947bfeb683ec877a8 on master.

codecov-io commented 8 years ago

Current coverage is 95.34% (diff: 81.48%)

Merging #28 into master will increase coverage by 2.09%

@@             master        #28   diff @@
==========================================
  Files            26         27     +1   
  Lines          1720       1719     -1   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           1604       1639    +35   
+ Misses          116         80    -36   
  Partials          0          0          

Powered by Codecov. Last update 64814a4...4bb090c

coveralls commented 8 years ago

Coverage Status

Coverage increased (+2.3%) to 95.533% when pulling 0035a84ee3795168c3a0c9ab69877ed4d48d5fa3 on develop into 64814a4aa58c8cbfee1eec9947bfeb683ec877a8 on master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+2.3%) to 95.533% when pulling 72eb5ce39ba3deec3a01549ebb08038e9fca0844 on develop into 64814a4aa58c8cbfee1eec9947bfeb683ec877a8 on master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+2.3%) to 95.533% when pulling 415eb7b01e128274bf3ec8218c48b7516de4bfb4 on develop into 64814a4aa58c8cbfee1eec9947bfeb683ec877a8 on master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+2.3%) to 95.533% when pulling ff192fffa8aad524c7b2d861893c5007294a2b24 on develop into 64814a4aa58c8cbfee1eec9947bfeb683ec877a8 on master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+2.3%) to 95.533% when pulling ff192fffa8aad524c7b2d861893c5007294a2b24 on develop into 64814a4aa58c8cbfee1eec9947bfeb683ec877a8 on master.

nbougalis commented 8 years ago

@vinniefalco: Please cherry-pick 6fe05f2acc8fcef7a841adaec71975ed79154602 to get some improvements for Buffer, including fixing an incorrect return in the copy constructor, fixing a bug in the move-assignment operator that could have left the object in an inconsistent state, and ensuring that there is no UB when copy-constructing Buffer objects or using Buffer operator(void const*, size_t).

Update: (Picked and squashed)

coveralls commented 8 years ago

Coverage Status

Coverage increased (+2.2%) to 95.475% when pulling 11cc7281dbe60f465fa345a7a0d18b83e8b476ba on develop into 64814a4aa58c8cbfee1eec9947bfeb683ec877a8 on master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+2.2%) to 95.475% when pulling 11cc7281dbe60f465fa345a7a0d18b83e8b476ba on develop into 64814a4aa58c8cbfee1eec9947bfeb683ec877a8 on master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+2.2%) to 95.475% when pulling aa981789d9597c0a90b1d8b74d4206d9549b8f81 on develop into 64814a4aa58c8cbfee1eec9947bfeb683ec877a8 on master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+2.2%) to 95.473% when pulling ca41d0b799e47f21812c5f7208c535e1c28ee7c9 on develop into 64814a4aa58c8cbfee1eec9947bfeb683ec877a8 on master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+2.2%) to 95.473% when pulling ed8ba0817b3053cf6042c25bafbd77b6f0299100 on develop into 64814a4aa58c8cbfee1eec9947bfeb683ec877a8 on master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+2.2%) to 95.415% when pulling ed8ba0817b3053cf6042c25bafbd77b6f0299100 on develop into 64814a4aa58c8cbfee1eec9947bfeb683ec877a8 on master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+2.1%) to 95.402% when pulling 4626bf5f60ca269b6079e8140698267b4aa9d8a7 on develop into 64814a4aa58c8cbfee1eec9947bfeb683ec877a8 on master.

miguelportilla commented 8 years ago

:+1:

vinniefalco commented 8 years ago

This needs Scott's bench changes before it can be merged

coveralls commented 8 years ago

Coverage Status

Coverage increased (+2.09%) to 95.346% when pulling 497c66088442255fa8d2a10d652f4e80dc8e5492 on develop into 64814a4aa58c8cbfee1eec9947bfeb683ec877a8 on master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+2.03%) to 95.288% when pulling 8829b4c8e19cb3111fb036de936040e617d453f1 on develop into 64814a4aa58c8cbfee1eec9947bfeb683ec877a8 on master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+2.09%) to 95.346% when pulling e969a3ea1ec7344f2f7c19ecc31a3168c17a765d on develop into 64814a4aa58c8cbfee1eec9947bfeb683ec877a8 on master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+2.03%) to 95.288% when pulling 644bcfa06484df00b1ea2da210064dac27bfbba5 on develop into 64814a4aa58c8cbfee1eec9947bfeb683ec877a8 on master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+2.09%) to 95.346% when pulling 973069406ede8bcbf6f714ea2394769c509ab9dc on develop into 64814a4aa58c8cbfee1eec9947bfeb683ec877a8 on master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+1.6%) to 94.823% when pulling 575b47765b5341395d6c5929040ea1316f169af5 on develop into 64814a4aa58c8cbfee1eec9947bfeb683ec877a8 on master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+2.03%) to 95.288% when pulling 575b47765b5341395d6c5929040ea1316f169af5 on develop into 64814a4aa58c8cbfee1eec9947bfeb683ec877a8 on master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+2.09%) to 95.346% when pulling 6403f26ebfdf79d48c8400e652823cbe19ee7721 on develop into 64814a4aa58c8cbfee1eec9947bfeb683ec877a8 on master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+2.09%) to 95.346% when pulling 6403f26ebfdf79d48c8400e652823cbe19ee7721 on develop into 64814a4aa58c8cbfee1eec9947bfeb683ec877a8 on master.

wilsonianb commented 8 years ago

LGTM :+1:

coveralls commented 8 years ago

Coverage Status

Coverage increased (+2.09%) to 95.346% when pulling b63f91d2ec0e4292869eba180b7e961841fbc1d8 on develop into 64814a4aa58c8cbfee1eec9947bfeb683ec877a8 on master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+2.03%) to 95.288% when pulling 740827863dfe366e9ded9c80b09c444ff979f83c on develop into 64814a4aa58c8cbfee1eec9947bfeb683ec877a8 on master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+2.03%) to 95.288% when pulling 29fb4fe0e83d890f7a47cf591321a2380f1a1003 on develop into 64814a4aa58c8cbfee1eec9947bfeb683ec877a8 on master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+2.09%) to 95.346% when pulling 4bb090cc191ba719351a75fb846329f77cb0d83c on develop into 64814a4aa58c8cbfee1eec9947bfeb683ec877a8 on master.