"insert" command - Githubissues

MarkusTeufelberger commented 8 years ago

Related to https://github.com/vinniefalco/NuDB/issues/7, see also the discussion there why I renamed "key" to "keyfile" in some locations.

Since both "create" and "fetch" are not yet implemented, properly testing this is a bit difficult... so this might blow up in various ways. You have been warned.

"Key" and "Value" will just take anything that http://www.cplusplus.com/reference/cstdlib/strtol/ performed on pairs of characters can process - this means that these need to have even length and I suspect that prefixing "0x" to them is NOT a good idea. This way it is possible to try to insert too short/long keys (or values).

Commits still need to be squashed, code needs to be more/less commented etc.

MarkusTeufelberger commented 8 years ago

It builds, so it must be correct. :-)

coveralls commented 8 years ago

Coverage increased (+0.06%) to 96.61% when pulling 0efda657ef8c9bf001d7f362157dbb585b60d329 on MarkusTeufelberger:master into 95824421c07b198159b809059f417a24994659bc on vinniefalco:master.

codecov-io commented 8 years ago

Current coverage is 96.61% (diff: 100%)

Merging #45 into master will not change coverage

@@             master        #45   diff @@
==========================================
  Files            28         28          
  Lines          1711       1711          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           1653       1653          
  Misses           58         58          
  Partials          0          0

Powered by Codecov. Last update 9582442...0efda65

vinniefalco commented 5 years ago

Not happening

cppalliance / NuDB

"insert" command #45

Current coverage is 96.61% (diff: 100%)