Closed ghost closed 4 years ago
The author of the commit is not properly linked to the GitHub account, probably because the email in the commit doesn't match the email of the GitHub account for @p2peer . Please fix the commit and then we can merge it.
Merging #79 into develop will decrease coverage by
1.37%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## develop #79 +/- ##
===========================================
- Coverage 94.55% 93.18% -1.38%
===========================================
Files 29 29
Lines 1891 1892 +1
===========================================
- Hits 1788 1763 -25
- Misses 103 129 +26
Impacted Files | Coverage Δ | |
---|---|---|
include/nudb/impl/create.ipp | 100.00% <100.00%> (ø) |
|
include/nudb/impl/context.ipp | 79.66% <0.00%> (-5.94%) |
:arrow_down: |
include/nudb/impl/basic_store.ipp | 87.35% <0.00%> (-5.34%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update fef02e0...650d3c4. Read the comment docs.
These changes are missing tests and coverage
These changes are missing tests and coverage
I added one function create() with uid parameter. This function is called by old function create() without uid parameter. Since old function is called by tests, new function is called by tests too. So I don't understand why coverage decreased.
make_uid
needs to be added to the Quick Reference:
https://github.com/CPPAlliance/NuDB/blob/master/doc/quickref.xml
Might want to add make_salt
too, since I see that it is missing.
Deterministic shards of rippled require fixed uid of database. To provide this functionality, new function create() is introduced which have additional uid parameter.