Closed ghost closed 3 years ago
Merging #82 into develop will increase coverage by
0.36%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## develop #82 +/- ##
===========================================
+ Coverage 93.18% 93.55% +0.36%
===========================================
Files 29 29
Lines 1892 1892
===========================================
+ Hits 1763 1770 +7
+ Misses 129 122 -7
Impacted Files | Coverage Δ | |
---|---|---|
include/nudb/context.hpp | 100.00% <ø> (ø) |
|
include/nudb/impl/context.ipp | 85.59% <ø> (+5.93%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update c5e7c0f...eac1da0. Read the comment docs.
Changes look good, missing unit test coverage in NuDB/test/context.cpp
.
"Addressing review comments" is not really descriptive of the contents of the commit
"Addressing review comments" is not really descriptive of the contents of the commit
Merged this commit with previous.
Changes look good, missing unit test coverage in
NuDB/test/context.cpp
.
Wrote test for flush() in NuDB/test/context.cpp. Test succeeded if include it into build.
This function manually flushes all inserted records to the disk. Needed for rippled deterministic shards.