Ellint coverage

[ckormanyos]

The purpose of this PR is to hit some missing ellint_1() and ellint_2() lines via adding tests and also to annotate some lines discovered that are not intended to be covered.

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 96.40288% with 5 lines in your changes missing coverage. Please review.

Project coverage is 98.5%. Comparing base (d9dc532) to head (43525f2).

Additional details and impacted files

[](https://app.codecov.io/gh/cppalliance/decimal/pull/666?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance) ```diff @@ Coverage Diff @@ ## develop #666 +/- ## ========================================= + Coverage 98.3% 98.5% +0.3% ========================================= Files 223 223 Lines 16112 16176 +64 Branches 1776 1789 +13 ========================================= + Hits 15823 15931 +108 + Misses 289 245 -44 ``` | [Files](https://app.codecov.io/gh/cppalliance/decimal/pull/666?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance) | Coverage Δ | | |---|---|---| | [include/boost/decimal/detail/cmath/cos.hpp](https://app.codecov.io/gh/cppalliance/decimal/pull/666?src=pr&el=tree&filepath=include%2Fboost%2Fdecimal%2Fdetail%2Fcmath%2Fcos.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance#diff-aW5jbHVkZS9ib29zdC9kZWNpbWFsL2RldGFpbC9jbWF0aC9jb3MuaHBw) | `100.0% <100.0%> (ø)` | | | [include/boost/decimal/detail/cmath/ellint\_1.hpp](https://app.codecov.io/gh/cppalliance/decimal/pull/666?src=pr&el=tree&filepath=include%2Fboost%2Fdecimal%2Fdetail%2Fcmath%2Fellint_1.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance#diff-aW5jbHVkZS9ib29zdC9kZWNpbWFsL2RldGFpbC9jbWF0aC9lbGxpbnRfMS5ocHA=) | `100.0% <100.0%> (+6.3%)` | :arrow_up: | | [include/boost/decimal/detail/cmath/ellint\_2.hpp](https://app.codecov.io/gh/cppalliance/decimal/pull/666?src=pr&el=tree&filepath=include%2Fboost%2Fdecimal%2Fdetail%2Fcmath%2Fellint_2.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance#diff-aW5jbHVkZS9ib29zdC9kZWNpbWFsL2RldGFpbC9jbWF0aC9lbGxpbnRfMi5ocHA=) | `100.0% <100.0%> (+6.0%)` | :arrow_up: | | [...de/boost/decimal/detail/cmath/impl/ellint\_impl.hpp](https://app.codecov.io/gh/cppalliance/decimal/pull/666?src=pr&el=tree&filepath=include%2Fboost%2Fdecimal%2Fdetail%2Fcmath%2Fimpl%2Fellint_impl.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance#diff-aW5jbHVkZS9ib29zdC9kZWNpbWFsL2RldGFpbC9jbWF0aC9pbXBsL2VsbGludF9pbXBsLmhwcA==) | `100.0% <100.0%> (+13.4%)` | :arrow_up: | | [test/compare\_dec128\_and\_fast.cpp](https://app.codecov.io/gh/cppalliance/decimal/pull/666?src=pr&el=tree&filepath=test%2Fcompare_dec128_and_fast.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance#diff-dGVzdC9jb21wYXJlX2RlYzEyOF9hbmRfZmFzdC5jcHA=) | `69.9% <ø> (+16.2%)` | :arrow_up: | | [test/test\_asin.cpp](https://app.codecov.io/gh/cppalliance/decimal/pull/666?src=pr&el=tree&filepath=test%2Ftest_asin.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance#diff-dGVzdC90ZXN0X2FzaW4uY3Bw) | `100.0% <ø> (+3.3%)` | :arrow_up: | | [test/test\_ellint\_1.cpp](https://app.codecov.io/gh/cppalliance/decimal/pull/666?src=pr&el=tree&filepath=test%2Ftest_ellint_1.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance#diff-dGVzdC90ZXN0X2VsbGludF8xLmNwcA==) | `100.0% <100.0%> (ø)` | | | [test/test\_ellint\_2.cpp](https://app.codecov.io/gh/cppalliance/decimal/pull/666?src=pr&el=tree&filepath=test%2Ftest_ellint_2.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance#diff-dGVzdC90ZXN0X2VsbGludF8yLmNwcA==) | `100.0% <100.0%> (ø)` | | | [...clude/boost/decimal/detail/cmath/impl/sin\_impl.hpp](https://app.codecov.io/gh/cppalliance/decimal/pull/666?src=pr&el=tree&filepath=include%2Fboost%2Fdecimal%2Fdetail%2Fcmath%2Fimpl%2Fsin_impl.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance#diff-aW5jbHVkZS9ib29zdC9kZWNpbWFsL2RldGFpbC9jbWF0aC9pbXBsL3Npbl9pbXBsLmhwcA==) | `62.8% <50.0%> (ø)` | | | [include/boost/decimal/detail/cmath/sin.hpp](https://app.codecov.io/gh/cppalliance/decimal/pull/666?src=pr&el=tree&filepath=include%2Fboost%2Fdecimal%2Fdetail%2Fcmath%2Fsin.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance#diff-aW5jbHVkZS9ib29zdC9kZWNpbWFsL2RldGFpbC9jbWF0aC9zaW4uaHBw) | `92.2% <85.0%> (-4.5%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/cppalliance/decimal/pull/666/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/cppalliance/decimal/pull/666?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/cppalliance/decimal/pull/666?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance). Last update [d9dc532...43525f2](https://app.codecov.io/gh/cppalliance/decimal/pull/666?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance).

[ckormanyos]

Better, good enough to merge but we will finish even more later