Add `-Wextra -Werror` to b2 builds

cmazakas commented 8 months ago

Update our b2 CI to be fully clean under -Wextra -Werror for all toolchains.

codecov[bot] commented 8 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (6507175) 88.05% compared to head (29c915b) 85.11%.

Additional details and impacted files

[![Impacted file tree graph](https://app.codecov.io/gh/cppalliance/http_proto/pull/49/graphs/tree.svg?width=650&height=150&src=pr&token=IoZbqjUnBr&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance)](https://app.codecov.io/gh/cppalliance/http_proto/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance) ```diff @@ Coverage Diff @@ ## develop #49 +/- ## =========================================== - Coverage 88.05% 85.11% -2.94% =========================================== Files 200 77 -123 Lines 11599 4200 -7399 =========================================== - Hits 10213 3575 -6638 + Misses 1386 625 -761 ``` | [Files](https://app.codecov.io/gh/cppalliance/http_proto/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance) | Coverage Δ | | |---|---|---| | [include/boost/http\_proto/detail/header.hpp](https://app.codecov.io/gh/cppalliance/http_proto/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance#diff-aW5jbHVkZS9ib29zdC9odHRwX3Byb3RvL2RldGFpbC9oZWFkZXIuaHBw) | `100.00% <ø> (ø)` | | | [include/boost/http\_proto/detail/impl/workspace.hpp](https://app.codecov.io/gh/cppalliance/http_proto/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance#diff-aW5jbHVkZS9ib29zdC9odHRwX3Byb3RvL2RldGFpbC9pbXBsL3dvcmtzcGFjZS5ocHA=) | `97.87% <ø> (ø)` | | | [include/boost/http\_proto/fields\_base.hpp](https://app.codecov.io/gh/cppalliance/http_proto/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance#diff-aW5jbHVkZS9ib29zdC9odHRwX3Byb3RvL2ZpZWxkc19iYXNlLmhwcA==) | `100.00% <ø> (ø)` | | | [include/boost/http\_proto/fields\_view\_base.hpp](https://app.codecov.io/gh/cppalliance/http_proto/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance#diff-aW5jbHVkZS9ib29zdC9odHRwX3Byb3RvL2ZpZWxkc192aWV3X2Jhc2UuaHBw) | `100.00% <ø> (ø)` | | | [include/boost/http\_proto/rfc/detail/rules.hpp](https://app.codecov.io/gh/cppalliance/http_proto/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance#diff-aW5jbHVkZS9ib29zdC9odHRwX3Byb3RvL3JmYy9kZXRhaWwvcnVsZXMuaHBw) | `100.00% <ø> (ø)` | | | [src/detail/header.cpp](https://app.codecov.io/gh/cppalliance/http_proto/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance#diff-c3JjL2RldGFpbC9oZWFkZXIuY3Bw) | `94.01% <100.00%> (ø)` | | | [src/fields\_base.cpp](https://app.codecov.io/gh/cppalliance/http_proto/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance#diff-c3JjL2ZpZWxkc19iYXNlLmNwcA==) | `93.09% <100.00%> (+0.01%)` | :arrow_up: | | [src/fields\_view\_base.cpp](https://app.codecov.io/gh/cppalliance/http_proto/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance#diff-c3JjL2ZpZWxkc192aWV3X2Jhc2UuY3Bw) | `95.89% <100.00%> (+0.08%)` | :arrow_up: | | [src/file\_posix.cpp](https://app.codecov.io/gh/cppalliance/http_proto/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance#diff-c3JjL2ZpbGVfcG9zaXguY3Bw) | `83.44% <100.00%> (ø)` | | | [src/message\_base.cpp](https://app.codecov.io/gh/cppalliance/http_proto/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance#diff-c3JjL21lc3NhZ2VfYmFzZS5jcHA=) | `85.34% <100.00%> (ø)` | | | ... and [4 more](https://app.codecov.io/gh/cppalliance/http_proto/pull/49?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance) | | ... and [123 files with indirect coverage changes](https://app.codecov.io/gh/cppalliance/http_proto/pull/49/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/cppalliance/http_proto/pull/49?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/cppalliance/http_proto/pull/49?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance). Last update [6507175...29c915b](https://app.codecov.io/gh/cppalliance/http_proto/pull/49?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance).