cppalliance / http_proto

HTTP/1 parsing and serialization algorithms using C++11
https://develop.http-proto.cpp.al/
Boost Software License 1.0
23 stars 10 forks source link

Feature/obs deprecation dev #61

Closed vinniefalco closed 7 months ago

cppalliance-bot commented 7 months ago

GCOVR code coverage report https://61.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://61.http-proto.prtest.cppalliance.org/genhtml/index.html Coverage Diff https://61.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

cppalliance-bot commented 7 months ago

GCOVR code coverage report https://61.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://61.http-proto.prtest.cppalliance.org/genhtml/index.html Coverage Diff https://61.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

cppalliance-bot commented 7 months ago

GCOVR code coverage report https://61.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://61.http-proto.prtest.cppalliance.org/genhtml/index.html Coverage Diff https://61.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

codecov[bot] commented 7 months ago

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (a8f7c92) 85.18% compared to head (c3f5073) 85.45%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/cppalliance/http_proto/pull/61/graphs/tree.svg?width=650&height=150&src=pr&token=IoZbqjUnBr&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance)](https://app.codecov.io/gh/cppalliance/http_proto/pull/61?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance) ```diff @@ Coverage Diff @@ ## develop #61 +/- ## =========================================== + Coverage 85.18% 85.45% +0.26% =========================================== Files 77 77 Lines 4199 4269 +70 =========================================== + Hits 3577 3648 +71 + Misses 622 621 -1 ``` | [Files](https://app.codecov.io/gh/cppalliance/http_proto/pull/61?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance) | Coverage Δ | | |---|---|---| | [include/boost/http\_proto/fields.hpp](https://app.codecov.io/gh/cppalliance/http_proto/pull/61?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance#diff-aW5jbHVkZS9ib29zdC9odHRwX3Byb3RvL2ZpZWxkcy5ocHA=) | `100.00% <ø> (ø)` | | | [include/boost/http\_proto/fields\_base.hpp](https://app.codecov.io/gh/cppalliance/http_proto/pull/61?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance#diff-aW5jbHVkZS9ib29zdC9odHRwX3Byb3RvL2ZpZWxkc19iYXNlLmhwcA==) | `100.00% <100.00%> (ø)` | | | [include/boost/http\_proto/impl/parser.hpp](https://app.codecov.io/gh/cppalliance/http_proto/pull/61?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance#diff-aW5jbHVkZS9ib29zdC9odHRwX3Byb3RvL2ltcGwvcGFyc2VyLmhwcA==) | `81.81% <ø> (ø)` | | | [include/boost/http\_proto/rfc/detail/rules.hpp](https://app.codecov.io/gh/cppalliance/http_proto/pull/61?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance#diff-aW5jbHVkZS9ib29zdC9odHRwX3Byb3RvL3JmYy9kZXRhaWwvcnVsZXMuaHBw) | `100.00% <ø> (ø)` | | | [src/error.cpp](https://app.codecov.io/gh/cppalliance/http_proto/pull/61?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance#diff-c3JjL2Vycm9yLmNwcA==) | `92.98% <100.00%> (+0.12%)` | :arrow_up: | | [src/fields.cpp](https://app.codecov.io/gh/cppalliance/http_proto/pull/61?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance#diff-c3JjL2ZpZWxkcy5jcHA=) | `100.00% <100.00%> (ø)` | | | [src/rfc/detail/rules.cpp](https://app.codecov.io/gh/cppalliance/http_proto/pull/61?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance#diff-c3JjL3JmYy9kZXRhaWwvcnVsZXMuY3Bw) | `95.67% <100.00%> (+3.06%)` | :arrow_up: | | [src/request.cpp](https://app.codecov.io/gh/cppalliance/http_proto/pull/61?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance#diff-c3JjL3JlcXVlc3QuY3Bw) | `75.00% <60.00%> (ø)` | | | [src/fields\_base.cpp](https://app.codecov.io/gh/cppalliance/http_proto/pull/61?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance#diff-c3JjL2ZpZWxkc19iYXNlLmNwcA==) | `93.33% <95.52%> (+0.23%)` | :arrow_up: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/cppalliance/http_proto/pull/61?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/cppalliance/http_proto/pull/61?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance). Last update [a8f7c92...c3f5073](https://app.codecov.io/gh/cppalliance/http_proto/pull/61?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance).
cppalliance-bot commented 7 months ago

GCOVR code coverage report https://61.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://61.http-proto.prtest.cppalliance.org/genhtml/index.html Coverage Diff https://61.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

cppalliance-bot commented 7 months ago

GCOVR code coverage report https://61.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://61.http-proto.prtest.cppalliance.org/genhtml/index.html Coverage Diff https://61.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

cppalliance-bot commented 7 months ago

GCOVR code coverage report https://61.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://61.http-proto.prtest.cppalliance.org/genhtml/index.html Coverage Diff https://61.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

cppalliance-bot commented 7 months ago

GCOVR code coverage report https://61.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://61.http-proto.prtest.cppalliance.org/genhtml/index.html Coverage Diff https://61.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

cppalliance-bot commented 7 months ago

GCOVR code coverage report https://61.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://61.http-proto.prtest.cppalliance.org/genhtml/index.html Coverage Diff https://61.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

cppalliance-bot commented 7 months ago

GCOVR code coverage report https://61.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://61.http-proto.prtest.cppalliance.org/genhtml/index.html Coverage Diff https://61.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

cppalliance-bot commented 7 months ago

GCOVR code coverage report https://61.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://61.http-proto.prtest.cppalliance.org/genhtml/index.html Coverage Diff https://61.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

cppalliance-bot commented 7 months ago

GCOVR code coverage report https://61.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://61.http-proto.prtest.cppalliance.org/genhtml/index.html Coverage Diff https://61.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

cppalliance-bot commented 7 months ago

GCOVR code coverage report https://61.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://61.http-proto.prtest.cppalliance.org/genhtml/index.html Coverage Diff https://61.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

vinniefalco commented 7 months ago

This looks good now! Merge it when you feel it is ready

cppalliance-bot commented 7 months ago

GCOVR code coverage report https://61.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://61.http-proto.prtest.cppalliance.org/genhtml/index.html Coverage Diff https://61.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt