fix: buffer preparation in serializer

cppalliance-bot commented 8 months ago

GCOVR code coverage report https://66.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://66.http-proto.prtest.cppalliance.org/genhtml/index.html Coverage Diff https://66.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 95.83333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 86.24%. Comparing base (e1b4aa1) to head (6dec1c6). Report is 3 commits behind head on develop.

Additional details and impacted files

[![Impacted file tree graph](https://app.codecov.io/gh/cppalliance/http_proto/pull/66/graphs/tree.svg?width=650&height=150&src=pr&token=IoZbqjUnBr&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance)](https://app.codecov.io/gh/cppalliance/http_proto/pull/66?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance) ```diff @@ Coverage Diff @@ ## develop #66 +/- ## =========================================== + Coverage 85.45% 86.24% +0.78% =========================================== Files 77 77 Lines 4269 4267 -2 =========================================== + Hits 3648 3680 +32 + Misses 621 587 -34 ``` | [Files](https://app.codecov.io/gh/cppalliance/http_proto/pull/66?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance) | Coverage Δ | | |---|---|---| | [src/serializer.cpp](https://app.codecov.io/gh/cppalliance/http_proto/pull/66?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance#diff-c3JjL3NlcmlhbGl6ZXIuY3Bw) | `72.52% <95.83%> (-0.05%)` | :arrow_down: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/cppalliance/http_proto/pull/66/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/cppalliance/http_proto/pull/66?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/cppalliance/http_proto/pull/66?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance). Last update [e1b4aa1...6dec1c6](https://app.codecov.io/gh/cppalliance/http_proto/pull/66?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cppalliance).

cppalliance-bot commented 8 months ago

GCOVR code coverage report https://66.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://66.http-proto.prtest.cppalliance.org/genhtml/index.html Coverage Diff https://66.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

cmazakas commented 8 months ago

We're going to probably want to add a test case here that demonstrates the issue.

ashtum commented 8 months ago

I'm going to add tests for using serializer with a http_proto::source instance. this should reproduce the issue.

cppalliance-bot commented 8 months ago

GCOVR code coverage report https://66.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://66.http-proto.prtest.cppalliance.org/genhtml/index.html Coverage Diff https://66.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

cppalliance-bot commented 8 months ago

GCOVR code coverage report https://66.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://66.http-proto.prtest.cppalliance.org/genhtml/index.html Coverage Diff https://66.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

cppalliance-bot commented 8 months ago

GCOVR code coverage report https://66.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://66.http-proto.prtest.cppalliance.org/genhtml/index.html Coverage Diff https://66.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

cppalliance-bot commented 8 months ago

GCOVR code coverage report https://66.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://66.http-proto.prtest.cppalliance.org/genhtml/index.html Coverage Diff https://66.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

cppalliance-bot commented 8 months ago

GCOVR code coverage report https://66.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://66.http-proto.prtest.cppalliance.org/genhtml/index.html Coverage Diff https://66.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

cppalliance-bot commented 8 months ago

GCOVR code coverage report https://66.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://66.http-proto.prtest.cppalliance.org/genhtml/index.html Coverage Diff https://66.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

cmazakas commented 8 months ago

The test changes seemed good on paper but I'm not sure I understand the problem this code is solving because I can comment things and tests will still pass for me locally so I think I need some clarification on what's going on here and how we're fixing it.

cppalliance-bot commented 8 months ago

GCOVR code coverage report https://66.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://66.http-proto.prtest.cppalliance.org/genhtml/index.html Coverage Diff https://66.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

cppalliance-bot commented 8 months ago

GCOVR code coverage report https://66.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://66.http-proto.prtest.cppalliance.org/genhtml/index.html Coverage Diff https://66.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

cppalliance-bot commented 8 months ago

GCOVR code coverage report https://66.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://66.http-proto.prtest.cppalliance.org/genhtml/index.html Coverage Diff https://66.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

cppalliance-bot commented 8 months ago

GCOVR code coverage report https://66.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://66.http-proto.prtest.cppalliance.org/genhtml/index.html Coverage Diff https://66.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

cppalliance-bot commented 8 months ago

GCOVR code coverage report https://66.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://66.http-proto.prtest.cppalliance.org/genhtml/index.html Coverage Diff https://66.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

cppalliance-bot commented 8 months ago

GCOVR code coverage report https://66.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://66.http-proto.prtest.cppalliance.org/genhtml/index.html Coverage Diff https://66.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

cppalliance / http_proto

fix: buffer preparation in serializer #66

Codecov Report