search

cppalliance / http_proto

HTTP/1 parsing and serialization algorithms using C++11
https://develop.http-proto.cpp.al/
Boost Software License 1.0
23 stars 10 forks source link

Fix/body avail assertion #95

Closed cmazakas closed 3 months ago

cmazakas commented 3 months ago

OSX and other platforms hit assertion failures because we were reading a non-initialized data member.

First order of business is making the assert() more strict so more platforms consistently fail on CI. Second order of business is to fix this at its root: just use NSDMI. The initialization routines in http-proto are too complex to track so it's easier to fix this at inception.

The third and final order of business is to get the chunked parsing routines to properly update the body_avail_ data member, which it wasn't doing before.

cppalliance-bot commented 3 months ago

Antora version: an automated preview of the documentation is available at https://95.http-proto.prtest.cppalliance.org/site/index.html

cppalliance-bot commented 3 months ago

GCOVR code coverage report https://95.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://95.http-proto.prtest.cppalliance.org/genhtml/index.html Coverage Diff https://95.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

cppalliance-bot commented 3 months ago

Antora version: an automated preview of the documentation is available at https://95.http-proto.prtest.cppalliance.org/site/index.html

cppalliance-bot commented 3 months ago

GCOVR code coverage report https://95.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://95.http-proto.prtest.cppalliance.org/genhtml/index.html Coverage Diff https://95.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

cppalliance-bot commented 3 months ago

Antora version: an automated preview of the documentation is available at https://95.http-proto.prtest.cppalliance.org/site/index.html

cppalliance-bot commented 3 months ago

GCOVR code coverage report https://95.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://95.http-proto.prtest.cppalliance.org/genhtml/index.html Coverage Diff https://95.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

cppalliance-bot commented 3 months ago

Antora version: an automated preview of the documentation is available at https://95.http-proto.prtest.cppalliance.org/site/index.html

cppalliance-bot commented 3 months ago

GCOVR code coverage report https://95.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://95.http-proto.prtest.cppalliance.org/genhtml/index.html Coverage Diff https://95.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt