search

cppforlife / turbulence-release

Turbulence release is used for injecting failure scenarios into any BOSH deployment.
Apache License 2.0
49 stars 17 forks source link

Can't update submodules #10

Closed benmoss closed 7 years ago

benmoss commented 7 years ago

When you clone this repo and run git submodule update, it fails with fatal: No url found for submodule path 'src/github.com/onsi/ginkgo' in .gitmodules

We are trying to submodule this release in our repo, and so when we recursively clone this project it fails. It looks like you need to commit the .gitmodules file.

cppforlife commented 7 years ago

there is no submodules in this repo, hence git submodule update isnt required.

Sent from my iPhone

On Jan 17, 2017, at 11:28 AM, Ben Moss notifications@github.com wrote:

When you clone this repo and run git submodule update, it fails with fatal: No url found for submodule path 'src/github.com/onsi/ginkgo' in .gitmodules

We are trying to submodule this release in our repo, and so when we recursively clone this project it fails. It looks like you need to commit the .gitmodules file.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

ekcasey commented 7 years ago

When we submodule turbulence-release into our repo this issue prevents us from recursively updating submodules in our repo.

benmoss commented 7 years ago

git submodules are marked with the file mode 160000 (https://longair.net/blog/2010/06/02/git-submodules-explained/)

$ git ls-files --stage | grep 160000
160000 d94e2f4000332f62b356ecb2840c98f4218f5358 0   src/github.com/onsi/ginkgo
160000 a83829b6f1293c91addabc89d0571c246397bbf4 0   src/gopkg.in/yaml.v2
benmoss commented 7 years ago

ill send a pr to fix these

cppforlife commented 7 years ago

@benmoss looks like somehow they ended up there. removed them.