New Features - Githubissues

cppforlife / turbulence-release

Turbulence release is used for injecting failure scenarios into any BOSH deployment.

Apache License 2.0

49 stars 15 forks source link

New Features #25

Open mattiekat opened 6 years ago

mattiekat commented 6 years ago

Added:

PauseProcess
New functions to ControlNetwork (reordering, corruption, and duplication)
Network Shaping (Bandwidth Limiting)
BlockDNS
Timeout for Filldisk
TargetedBlocker

Fixed:

Issue #21

The docs have been updated with changes as well, so please see the API docs for complete use information.

karunchennuri commented 6 years ago

@cppforlife we added desired functionality from your previous future enhancements list. We are excited to contribute back to your repo with added functionality. Appreciate if you can please review and approve this PR. Please keep us posted on your thoughts and comments if any. Thanks

karunchennuri commented 6 years ago

@cppforlife just checking to see if you've any comments on this effort.

h0nIg commented 5 years ago

@cppforlife any chance this will get merged?

voelzmo commented 5 years ago

Hey @Eadword and @karunchennuri,

Thanks for the PR and the huge feature set that it adds! It seems that @cppforlife isn't going spend significant time on this, so let me try to find time to look at this.

One thing that makes it hard to look at the PR is that you are adding multiple features at the same time. Could you try to split this up into multiple PRs for the individual features you're adding?

PauseProcess --> PR
New functions to ControlNetwork (reordering, corruption, and duplication) --> PR
Network Shaping (Bandwidth Limiting) --> PR
Timeout for Filldisk --> PR
TargetedBlocker --> PR
- BlockDNS (can probably go into the same PR as the TargetedBlocker, as it is more of a special case of blocking)

This would make it much easier to test the corresponding functionalities and give feedback on the implementation. Sorry for the long wait, I certainly hope that we can merge this in 2019 ;)

karunchennuri commented 5 years ago

@voelzmo Thanks a lot. We can certainly do that. Also we have more other features we would love to add. Having said that given the fact PRs are taking time, is it ok if we create a new repo and credit this repo for true source of inspiration? Would love to know your thoughts on this please.

We credited Turbulence here https://www.youtube.com/watch?v=KMiNuGIV0mY&t=13m06s in our last year's talk. We've plans to add more capabilities going forward, please let us know what is the best way we can get the PRs for current and new ones quickly now and in future.

Will wait for you response. Thanks

voelzmo commented 5 years ago

Hi @karunchennuri,

is it ok if we create a new repo and credit this repo for true source of inspiration? Would love to know your thoughts on this please.

Sure, my assumption is you already have a fork of turbulence anyways. What would be your long-term plans for that repo? Would you want to keep it, or move back to this repo once your desired functionality is there?

please let us know what is the best way we can get the PRs for current and new ones quickly now and in future

Thanks for asking this! I think the best way is a twofold approach: First, open an issue to see if the features you're trying to implement make sense to a broader audience and potentially talk about how you're going to implement it. Secondly, open separate PRs for small increments, such that they can more easily be reasoned about and tested.

Does this make sense? Thanks, Marco

h0nIg commented 5 years ago

Hi @karunchennuri / @Eadword,

i added additional features based on this PR within https://github.com/cppforlife/turbulence-release/pull/27

Best, Hajo