search

cppfw / svgren

:camera: SVG rendering library in C++
MIT License
206 stars 41 forks source link

crash during render #37

Closed Papirosnik closed 7 years ago

Papirosnik commented 7 years ago

Hi there! I've updated to 0.4.42 because of performance issue on our nice sport car. Greats improvements! Car is rendered about 20 times faster!!! Then I tried other (previously hard-rendered) svgs and alas... some of them crash machupicchu.zip . Could you please locate and fix a problem? Thanks in advance!

igagis commented 7 years ago

Yep, I will have a look.

igagis commented 7 years ago

The crash is fixed in svgren 0.4.43. Should be there soon: https://ci.appveyor.com/project/igagis/svgren/build/master-443 https://travis-ci.org/igagis/svgren/builds/295725050

But I also noticed that these 4 images that you attached are rendererd differently by different software. I tried Firefox, Chrome, Internet Explorer, svgren. All these give different results at least for images 04 and 06. I suspect that IE does the best job. svgren is close to right result. Worst one was Chrome. So, in relation to this, could you create a separate issue and attach raster images of how those are expected to look, if you find that svgren does not render something correctly?

Papirosnik commented 7 years ago

I beg your pardon ) those svgs are wrong exported. I think they cannot be considered as samples. Anyway, thanks for the fix!

igagis commented 7 years ago

Hm, ok. But the crash should be fixed now.