svgren::render is deprecated

[alexatcm]

So I just start following your wiki how to, under vs2017 c++

include <svgren/render.hpp>

include <papki/FSFile.hpp> //we will need this to load the SVG file

void main(){ auto dom = svgdom::load(papki::FSFile("C:/Production/svg/samples/SampleSVGImage_23kbmb.svg")); unsigned width = 0; //0 means use width from SVG document unsigned height = 0; //0 means use height from SVG document auto img = svgren::render(*dom, width, height); };

and I got a console error saying me to use render (svg,p) !!!

Is that you guys does not update the wiki how to ? How to solve the issue

[igagis]

Yes, that function is deprecated, you need to use the new one.

See the new function here: https://github.com/igagis/svgren/blob/master/src/svgren/render.hpp#L67

Wiki was not updated due to lack of time

[goodyes]

So, can you update the wiki ? And or put a sample code for easy understand ?

[goodyes]

It is absolutely useless your code unless you provide a basic sample example code usage. You link to the function doew not provide any help, as there are new params than on the old deñrecated funtion. Please do your job correct, and put a samole code updating the wiki HOW TO

[igagis]

No, it is not absolutely useless, many people use my code successfully, that proves that it is not useless. And this is not my job, I'm not paid for this.

[alexatcm]

Yoir code is useless as of now. People used your code, but now you did not documented. New function has new parameters, NOT DOCUMENTED So you are only loosing the time of new users

El sábado, 15 de diciembre de 2018, Ivan Gagis notifications@github.com escribió:

No, it is not absolutely useless, many people use my code successfully, that proves that it is not useless. And this is not my job, I'm not paid for this.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/igagis/svgren/issues/61#issuecomment-447603589, or mute the thread https://github.com/notifications/unsubscribe-auth/ArxOZ6DCDWxRsIyCDwxmRLjJrpn1mOuGks5u5X0qgaJpZM4ZUrkr .

--

Alejandro - Equipo de Desarrollo Email: alex@cinemartin.com Cinemartin http://www.cinemartin.com

This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. This message contains confidential information and is intended only for the individual named. If you are not the named addressee please notify the sender immediately by e-mail. If you have received this e-mail by mistake delete this e-mail from your system. Disclosing, copying, or distributing any portion or information in reliance on the contents of this email is strictly prohibited.

[igagis]

So you are only loosing the time of new users

Please, don't use my code, don't waste your time.

[saeitsystems]

I dont' understand your problems. To me the code is very useful. There are many examples in the repository and anyway it is very easy to use. This is the SVG library with the easiest interface I found in the internet. And Ivan's support is very fast and good although he is not paid for it! So what is your real problem? Alexatcm and goodyes you working for a company with a paid SVG library?

It is absolutely useless your code unless you provide a basic sample example code usage. You link to the function doew not provide any help, as there are new params than on the old deñrecated funtion. Please do your job correct, and put a samole code updating the wiki HOW TO

[alexatcm]

I do not work for any lib paid company. I just see how bad is to have a code like you on the internet, that only waste time of people. I simply advertise other people to go other places. HELLO ARE YOU NEW ? Do not waste time in this project, IT IS undocumented and unsupported project with a guy hat simply says "this is not a paid project so go everywhere".. absolutely horrible under my opinion.

[saeitsystems]

I'm not new, but you seem to be new to github..... You just joined 2 days ago and immediately started complaining in a rude way. The function you mentioned is still working and from the header file you can easily see how the new interface to svgren::render is working. Where is your project so that I can check if you yourself meet your high standards

[igagis]

@alexatcm no need to advertise that to other people. Other people chose the library after doing an extensive research and they perfectly know what they choose. I will update the wiki page when I have time for that, and You could update the wiki yourself if you have time and make the library better for other people, I accept pull requests! But your complains in a rude form do not help at all...

[igagis]

Wiki page updated with latest API function

[goodyes]

thank you, well done En miércoles, 19 de diciembre de 2018 16:28:55 CET, Ivan Gagis notifications@github.com escribió:

Wiki page updated with latest API function

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.