search

cppisking / ffrk-inspector

Issues tracker for FFRK Inspector
10 stars 8 forks source link

Mislabeled Item - Bronze Helm from different Realm #54

Closed Endracion closed 9 years ago

Endracion commented 9 years ago

I can't give you the ID since I don't have access to it, but it's coming up as Bronze Helm (II), when it's actually the Bronze Helm (V); there are a few items with the same name but different realm RS.

http://i.imgur.com/1nonMwE.png

cppisking commented 9 years ago

Is it possible you actually do have multiple Bronze Helm (II)'s? I can't imagine how this could happen, the item name I print in the grid is the same as what's sent by the server. On Wed, Jun 3, 2015 at 7:38 AM Endracion notifications@github.com wrote:

I can't give you the ID since I don't have access to it, but it's coming up as Bronze Helm (II), when it's actually the Bronze Helm (V); there are a few items with the same name but different realm RS.

http://i.imgur.com/1nonMwE.png

— Reply to this email directly or view it on GitHub https://github.com/cppisking/ffrk-inspector/issues/54.

Endracion commented 9 years ago

No, I have multiple Bronze Helm (V) - what I'm saying is it's reporting the wrong Bronze Helm. I have 0 Bronze Helm (II)s.

I was saying that other than these Helms, the game has a few items that share the same name, but are actually different and separated by their Realm difference. It was probably unclear from my original post.

karryt commented 9 years ago

Are you very sure you don't have both? I have 1++ of both, guess they are both common 1* drops. Try sorting by Type and then scrolling down to the helms.

Endracion commented 9 years ago

You know what, I'm crazy, I do have triples of both - I looked it up on the website and I recognize the item thumbnail.

My bad!

cppisking commented 9 years ago

It was clear, it's just that I explicitly handle this case and it's supposed to be supported. And i thought (although I can't check the code right now) that the text I print in the name field is exactly what is sent by the game, which would mean the game is actually sending "Bronze Helm (II)".

I'll check the code, in the meantime do you mind going to the debugging tab and selecting the row on the left that says /dff/party/list and sending it to me? Your account id may be in there somewhere, so you can scrub it manually before posting here, or just email.

On Wed, Jun 3, 2015 at 8:24 AM Endracion notifications@github.com wrote:

No, I have multiple Bronze Helm (V) - what I'm saying is it's reporting the wrong Bronze Helm. I have 0 Bronze Helm (II)s.

I was saying that other than these Helms, the game has a few items that share the same name, but are actually different and separated by their Realm difference. It was probably unclear from my original post.

— Reply to this email directly or view it on GitHub https://github.com/cppisking/ffrk-inspector/issues/54#issuecomment-108481961 .

cppisking commented 9 years ago

Haha ok i was worried i was going crazy :). Cheers On Wed, Jun 3, 2015 at 8:30 AM Endracion notifications@github.com wrote:

You know what, I'm crazy, I do have triples of both - I looked it up on the website and I recognize the item thumbnail.

— Reply to this email directly or view it on GitHub https://github.com/cppisking/ffrk-inspector/issues/54#issuecomment-108485402 .