cprcrack / VideoEnabledWebView

Android's WebView and WebChromeClient class extensions that enable fully working HTML5 video support
MIT License
1.05k stars 289 forks source link

Example project gets rid of toggle fullscreen button. #5

Open amozoss opened 9 years ago

amozoss commented 9 years ago

https://github.com/cprcrack/VideoEnabledWebView/blob/master/app/src/main/java/name/cpr/ExampleActivity.java#L32-L39

I had to remove the linked lines of code for the toggle fullscreen button to appear in the embedded video player. Not really sure what is happening, but it works when onProgressChanged is not overridden with the constructor. I am using a nexus 5, lollipop.

QingLong20 commented 9 years ago

Same thing for me. Using Lollipop 5.0.2 on Samsung Galaxy S6. Removing the lines pointed out by @amozoss fixed the problem. It is still working correctly on Android KitKat 4.4.2 after removing the lines.