cpriest / SnapLinksPlus

Snap Links Plus is a Browser Addon that lets you lasso links, checkboxes and other elements do things with them.
Other
202 stars 35 forks source link

Feature Request: Open Tabs in drag order #239

Open RandomNerd1 opened 6 years ago

RandomNerd1 commented 6 years ago

Using this random page as an example:

https://www.daniel-photography.eu/Gallerie

Labeling those six links arranged on that page like so:

1 2 3 4 5 6

No matter what direction I drag over multiple links, if I drag over a row of them, they open in right-to-left order (e.g. 3-2-1 or 6-5-4), and if I drag over a column, they open in bottom-to-top order (e.g. 6-3 or 4-1). If I drag over all six links, they open in the order 6-5-4-3-2-1.

This seems like bizarre behavior. I would expect the links to open depending on the order in which they are selected if it's a row or column. In the third case, I'd expect it to make a best guess based on how the links are oriented (if I drag from 6 to 2, I'd expect the result to be 6-5-3-2 regardless of if the cursor), though it's much more forgiveable in my opinion if its best guess isn't perfect, especially for pages that aren't as neatly grid-like as my example page.

I'll mention that I use Tree Style Tab, just in case that makes a difference.

cpriest commented 6 years ago

I think this is already an open ticket. It has to do with opening the links in document order but inserting them after the active tab.

So dragging over all 6 of the links, it opens 1, then opens 2 before 1, then opens 3 before 2, then opens 4, 5, 6, inserting each just to the right of the active tab.

I'll put this up for the next release, shouldn't be hard to fix at all.

RandomNerd1 commented 6 years ago

Hey, I appreciate the prompt response!

I'll be looking out for the next release,k thanks! :)

btanner2 commented 6 years ago

+1

cpriest commented 5 years ago

This is not an issue if you check 'Open tabs at end of bar,' correct?

If that's not right and this is still an issue, please re-open.

RandomNerd1 commented 5 years ago

This is not an issue if you check 'Open tabs at end of bar,' correct?

If that's not right and this is still an issue, please re-open.

Well, if you check "Open tabs at end of bar", then the links now open left to right, no matter what order you select them in. I think the correct behavior should be to open them in the order that you drag across them, with vertical ordering taking precedence over horizontal. So, with a set of links arranged like:

1 2 3 4 5 6

if I drag from bottom left to top right, for example, it should open them in the order 4 5 6 1 2 3 bottom right to top left would open them 6 5 4 3 2 1 top left to bottom right would open them 1 2 3 4 5 6 and top right to bottom left would open them 3 2 1 6 5 4

Sorry if it's difficult to understand what I'm getting at. I don't think it was Snap Links, but I used to use an extension with this functionality that did this perfectly every time, and I think this behavior makes the most sense.

P.S. I don't see any way to reopen this issue.

cpriest commented 5 years ago

I'll leave this one open as an enhancement and look for people to vote on it.

It's possible, I'm just not sure how intuitive it would be for most people but I do like the idea of the control.

RlctntFr commented 5 years ago

+1

RandomNerd1 commented 5 years ago

+1

Appreciate this, I'm still holding out hope for this enhancement (which I would still consider a "fix" as it's the most intuitive behavior imo)

RlctntFr commented 5 years ago

To add to this, in the latest version the tabs appear to open in the correct order, but if you use a delay you can see the behavior is still weird. What happens now is they open in reverse order, but each tab is inserted to the left of the previous one. For instance if you open 5 tabs they open like this:

5 4 5 3 4 5 2 3 4 5 1 2 3 4 5

They end up in the correct order, but this becomes a problem if you (like me) want to use a delay and browse the tabs while they're still opening. You either have to view them in reverse order or else wait until the whole set is open before viewing. Note that this behavior is not affected by the "Open tabs at end of tab bar" setting. That setting only appears to affect the set as a whole and not the individual tabs.

I think ClefAria's idea of having drag direction decide opening order makes sense and would be a cool feature to add, but barring that I would at least expect the links to open sequentially. Hopefully that's not too complicated a fix.

cpriest commented 5 years ago

They end up in the correct order, but this becomes a problem if you (like me) want to use a delay and browse the tabs while they're still opening. You either have to view them That's interesting, I think that is an issue unto its-self. I would have thought they would not be affected by switching to one of the tabs during the delayed tab opening process. It certainly shouldn't need to be affected by it. @RlctntFr would you open this bug in a new ticket?

I just re-read this entire thread (old one now), I just want to be sure I'm clear on the current state (besides the aforementioned bug from RlctntFr).

At this point, this is a feature request to open tabs in drag order, right?

RandomNerd1 commented 5 years ago

At this point, this is a feature request to open tabs in drag order, right?

That's what I'm going for, yeah.