cpriest / SnapLinksPlus

Snap Links Plus is a Browser Addon that lets you lasso links, checkboxes and other elements do things with them.
Other
197 stars 35 forks source link

Windows/Firefox: Modifiers break SnapLinksPlus #440

Closed Prometheos2 closed 1 year ago

Prometheos2 commented 1 year ago

Hello,

I've noticed that the add-on does not open links on Firefox on Windows when a modifier is set. Having "No modifier" set makes the add-on open links properly.

I enabled all developer options in later attempts, but that did not fix the problem. I could send you the logs if you tell me where to find them.

Steps to reproduce

  1. Set "Ctrl" modifier
  2. Go to a website with links (e.g., https://cpriest.github.io/SnapLinksPlus/#/Tutorial)
  3. Select links/buttons with the lasso with Ctrl+RMB
cpriest commented 1 year ago

It's probably fighting with some other addon. also note that The modifiers selected need to be exactly those modifiers and no additional

Prometheos2 commented 1 year ago

It's probably fighting with some other addon.

That would be a problem, I have quite a few addons.

also note that The modifiers selected need to be exactly those modifiers and no additional I tried again to make sure, and now only Ctrl modifiers do not work, so I don't know if it's that or something else... I soft-reset Firefox yesterday, so maybe some of the blocking addons were removed.

I will check with Firefox troubleshooter mode, and come back at you.

edit: Nevermind, it blocks every addons.

Even with all other addons disabled (and browser restart), the bug seems to remain.

cpriest commented 1 year ago

I just realized what you're running into. The behavior is such that holding down control when releasing the button will cause it to do the opposite of the default action (which is to copy the links to the clipboard).

image

Prometheos2 commented 1 year ago

Glad to see you found the issue

Have a nice day!