cpriest / SnapLinksPlus

Snap Links Plus is a Browser Addon that lets you lasso links, checkboxes and other elements do things with them.
Other
197 stars 35 forks source link

Right clicking broken on YouTube #472

Open selimsum opened 4 months ago

selimsum commented 4 months ago

Right clicking (without dragging) anywhere on youtube.com randomly clicks somewhere on the page that the cursor is not pointing at. Single or multiple unwanted tabs are opened as a consequence.

This has been happening for a week or so. I can't reproduce this on any other websites, it's just YouTube.

My settings: Select elements when I hold down: No modifier and I right click and drag for 5 pixels

Browser: Firefox Nightly 127

cpriest commented 4 months ago

Is this on Linux? I just tested w/ Windows on FF/125 and it works as expected.

selimsum commented 4 months ago

Sorry, I should have mentioned earlier: It's Windows.

I've just tried creating a fresh Firefox profile and I can still reproduce it. Maybe it's a Nightly issue? I haven't tested with beta or stable.

selimsum commented 4 months ago

I've also noticed an additional blank tab with this URL: moz-extension://facfe2ca-c8b4-4bc1-a6d2-f36595f30421/_generated_background_page.html

samvan11 commented 3 months ago

I've also been experiencing this issue since upgrading to FF 126. It was working fine on FF 125. Creating a new profile didn't help.

So far, I have noticed it only on YouTube.

kaisersoze80 commented 3 months ago

Problem seems to be related to the body of the page having 0 as height in CSS.

As a work-around I temporarily solved it by forcing body { height: 1000px; }.

I accomplished that by using Stylus firefox extension.

Hope this can help devs to find the reason behind the issue, and fix it.

erik7777 commented 3 months ago

As mentioned, this just started happening with Youtube with the SnapLinksPlus Extension Active. The Conflict makes Youtube basically unusable without deactivating the Extension.

cpriest commented 3 months ago

This is on www.youtube.com? I'm using FF 127 (Developer version) and it works just fine in a private window with just snaplinks enabled for private windows (on Windows 11).

selimsum commented 3 months ago

This is on www.youtube.com? I'm using FF 127 (Developer version) and it works just fine in a private window with just snaplinks enabled for private windows (on Windows 11).

Correct, this only happens on www.youtube.com. I can still reproduce it on Firefox 128 (Nightly) on Windows 11.

cpriest commented 3 months ago

OK, I will watch when FF129 comes to the Developer channel and see what's going on.

selimsum commented 3 months ago

I've just tested with the latest Developer Edition (127.0b5) and made a recording to make sure we're on the same page.

This is a fresh installation. I haven't logged in to YouTube and only installed SnapLinksPlus. I've right clicked on video thumbnails for this recording.

https://github.com/cpriest/SnapLinksPlus/assets/1046789/4262d0e0-137e-4aa5-9967-1c6b6c2f09a9

cpriest commented 3 months ago
Thanks for that video, that helps a lot to see what's going on,
though I am not able to reproduce the issue.

I only quickly tested with my main profile, I will start a fresh
profile with just SnapLinks and see what I get shortly.
erik7777 commented 3 months ago

Hello, I am on Windows 11 with Firefox 126.0 (64 Bit). The Youtube Issue started after updating to Firefox 126.

Pressing Right Click on Youtube with SnapLinks Active does not produce the Right Click Menu, and instead opens multiple links instead.

Thanks for checking!

cjdjkobe commented 3 months ago

I, too, am having this issue, but to add to a note that might help with troubleshooting: shift-clicking will just open the regular rmb-window on both video and page. Does not return the lasso functionality, however.

Windows 10, 126.0.1 Firefox

Had it happen on another website, too, but didn't think to pay attention to what it was.

barbaduk commented 3 months ago

Thanks for that video, that helps a lot to see what's going on, though I am not able to reproduce the issue. I only quickly tested with my main profile, I will start a fresh profile with just SnapLinks and see what I get shortly.

Try it on 130% page scale (or maybe it's different for you) For me it works fine on 90%, 120%, 126%, but breaks at 100%, 110% 130%

cjdjkobe commented 3 months ago

Try it on 130% page scale (or maybe it's different for you) For me it works fine on 90%, 120%, 126%, but breaks at 100%, 110% 130%

Strangely, 130% works for me too.

erik7777 commented 3 months ago

I did not scale to 130%, but it works again for me too.

Since there was no Snaplinks update, Youtube must have corrected the problem.

Parsnip commented 3 months ago

Still broken here, so I did some testing.

Just to confirm here as well, on my end right click is broken on youtube, on normal 100% FF zoom, but works just fine on 70%, 110% and 120% zoom levels for example. It's really unusual behavior.

It doesn't seem to be directly connected to window size, since it occurs fullscreen and windowed Firefox.

Since the results seem to vary between people, my first thought is that it's somehow connected to screen resolution and Windows scale values not playing nice with FF scale values. Some quick testing seems to suggest that any (up to 4K at least) display resolution combined with Windows scaling set to 100% and Firefox scaling set to 100% and everything works as expected. Testing a bit more, on a 4K display resolution, keeping the FF scaling at the default 100%, and then going up the Windows scale in increments of 25%, things break the first time at Windows scale 200%.

So, who's good at math? 😄

erik7777 commented 3 months ago

I just checked again. The reason it started working for me was because I added a Second Monitor.

With Extended Display, everything works fine. With Duplicate Monitors, everything is still broken, regardless of the Resolution. I did not change scale settings.

blaharginhoogin commented 2 months ago

I can add some details to this SnapLinks - Youtube issue.!

If Youtube is open in Firefox maximized = issue persists.

If Youtube is open, but not maximized = the issue is gone!

Also, it seems the File Menu has to be visible in the browser.

Hopefully someone smarter than myself can use these details to figure out the issue.

Windows 10 Firefox SnapLinks: hold right lick+drag

samvan11 commented 2 months ago

The issue seems to be related to the zoom level. In my case, when it's 98% or lower, the sidebar becomes "full" with all available sections, and the issue is gone in that setting. When the zoom level is between 99-149%, it's broken.

Strangely, if it's 150% or higher, the issue is also gone, but it's not comfortable to view at such levels.

So, 98% is the sweetspot for me. It fixes the issue without sacrificing the zoom level much.

To make that level available on FF, you could add ".98" to the "toolkit.zoomManager.zoomValues" setting from about:config.

samvan11 commented 2 months ago

I've encountered another site that triggers the same issue. The zoom-out workaround also works on it.

Multiple sites with the same issue may help troubleshooting what they have in common and what causes it.

cjdjkobe commented 2 months ago

I've noticed this issue cropping up when you open a .jpg or other image from certain sites (but not all jpegs??), expand it to full size, then right click on it.

For instance, Instagram images

Parsnip commented 1 month ago

I noticed that the height: 1000px workaround messes up youtube embeds in (some?) other sites since the stylus is applied on the iframe embed as well. So I changed the snaplinks activation button to ctrl+mouse3 instead of right click for now as another workaround.

cpriest commented 1 month ago
Do you have a URL where I can see this
  happening?
anotatta commented 1 week ago

Still broken. On youtube, Zoom level greater than 95% is the sweet spot for me. If the site blacklist feature ( Feature Request: Blacklist #473 ) is implemented, then that would be a good workaround.