cprodhomme / arctic_admin

Responsive Theme for ActiveAdmin
https://arcticadmin.osc-fr1.scalingo.io
MIT License
295 stars 109 forks source link

[FEATURE] Support Font Awesome Pro #82

Closed sjieg closed 4 years ago

sjieg commented 4 years ago

Is your feature request related to a problem? Please describe. See #260 We include Font Awesome Free to let the icons work.

In the CSS code font family is hard defined:

font-family: 'Font Awesome Free 5';

Describe the solution you'd like

At all places where Font Awesome Free 5 is used, Font Awesome Pro 5 should also be included. For example:

  font-family: 'Font Awesome Free 5';
  font-weight: 900;

Should become

  font-family: 'Font Awesome Free 5', 'Font Awesome Pro 5';
  font-weight: 900;

This way both versions of Font Awesome should work:

<i class="fa-users" style="font-family: 'Font Awesome 5 Free'; font-weight: 900;"></i> Free
<br />
<i class="fa-users" style="font-family: 'Font Awesome 5 Pro'; font-weight: 900;"></i> Pro
<br />
<i class="fa-users" style="font-family: 'Font Awesome 5 Free', 'Font Awesome 5 Pro'; font-weight: 900;"></i> Both

Describe alternatives you've considered

Maybe the proper fix would be an ArcticAdmin or ActiveAdmin config setting in /config/initializers/active_admin.rb. But in that case it should be engineerd in a way that it will support other icon types as well.

For now I think hard-coding support for both free and pro is the easiest acceptable fix.

cprodhomme commented 4 years ago

This fix was publish in https://github.com/cprodhomme/arctic_admin/releases/tag/V3.2.1