search

cpsc455-bugstorm / TravelersTea

A Trip Planning App that tailors travel itineraries based on user preferences and providing detailed information about destinations; making travel planning less daunting and more enjoyable.
https://travelerstea-906d.onrender.com
MIT License
6 stars 2 forks source link

make globe spin #198

Closed vee-16 closed 9 months ago

vee-16 commented 9 months ago

source: https://docs.mapbox.com/mapbox-gl-js/example/globe-spin/

L0Lmaker commented 9 months ago

I love it 😍

L0Lmaker commented 9 months ago

One small issue is when the map is zoomed in it becomes fixed. Gonna look into it for a bit to see if we can get it to move while zoomed in.

vee-16 commented 9 months ago

One small issue is when the map is zoomed in it becomes fixed. Gonna look into it for a bit to see if we can get it to move while zoomed in.

I'll take a look so it seems to be locked in compact mode toggle, I will double check if this is consistent in main

(Edit: issue is currently in main, so unrelated to the changes of this PR. Good catch, we can add a commit to fix it here)

L0Lmaker commented 9 months ago

If its a problem on main then I think we are good for merge on this if no one else has any comments. @NLmeng @Graywing13 @AndyLiang1

L0Lmaker commented 9 months ago

Ooh I think you fixed it in this PR only 🤩