search

cpsc455-bugstorm / TravelersTea

A Trip Planning App that tailors travel itineraries based on user preferences and providing detailed information about destinations; making travel planning less daunting and more enjoyable.
https://travelerstea-906d.onrender.com
MIT License
6 stars 2 forks source link

When login/signup fails, user should get an alert #225

Closed Graywing13 closed 8 months ago

NLmeng commented 9 months ago

i omitted error info related to auth on purpose. if you want to add it i think its fine to include it for sign up, but not for login for security reasons.

Graywing13 commented 8 months ago

ah i see

had discord discussion that it's bad to tell em which part is incorrect, but it's ok to say "incorrect username or password" without specifying which one is wrong

so I'll write the PR and if it's still a issue, then we can just close the pr w/o merging

Graywing13 commented 8 months ago

never mind it seems like you already added it in #223