cpsc455-bugstorm / TravelersTea

A Trip Planning App that tailors travel itineraries based on user preferences and providing detailed information about destinations; making travel planning less daunting and more enjoyable.
https://travelerstea-906d.onrender.com
MIT License
6 stars 2 forks source link

Is it possible to move eslintrc and prettier files to root? #31

Closed L0Lmaker closed 11 months ago

L0Lmaker commented 11 months ago

Instead of having 2 separate ones.

L0Lmaker commented 11 months ago

@NLmeng can you take a look at this

L0Lmaker commented 11 months ago

Have assigned #32 to you as well so you can enable CI after you finish with this issue

NLmeng commented 11 months ago

reasons i did not move eslintrc and prettier files to root:

It is possible to combine them into root and let it cascade to all the files under root, if it is alright for everyone that we need to do 3 yarn installs instead of 2 and that we only use prettier (no specific lint for react, nodejs, etc.). in other words only check for these and nothing else { "semi": false, "trailingComma": "all", "singleQuote": true, "printWidth": 80, "tabWidth": 2 }

L0Lmaker commented 11 months ago

LGTM