Closed NLmeng closed 10 months ago
Looks good, thanks for making the changes!
Some suggestions:
given the width of the entry, i think more spaces between the icons would take too much space. do you think its too cramped? now it truncate only if the icons are there
I see, yeah it'd be too cramped Thx for the chances!
update: made the icons slightly smaller plus add a little spacing between:
As a note for next time, can we tackle issues in seperate PRs if possible? hard to know which changes are related to which in a large PR
it was in a separate PR
Those icons look good!
I changed Sidebar to use pixels instead of % because i think responsive sidebar is harder to manage the elements within it and it seems like most big websites have a fixed size sidebar until the screen gets really small. (i think it looks better this way)
I also changed the look / size of the elements in TripEntry to make it more visible.