cpsc455-bugstorm / TravelersTea

A Trip Planning App that tailors travel itineraries based on user preferences and providing detailed information about destinations; making travel planning less daunting and more enjoyable.
https://travelerstea-906d.onrender.com
MIT License
6 stars 2 forks source link

Changes to Sidebar and TripEntry #99

Closed NLmeng closed 10 months ago

NLmeng commented 11 months ago

I changed Sidebar to use pixels instead of % because i think responsive sidebar is harder to manage the elements within it and it seems like most big websites have a fixed size sidebar until the screen gets really small. (i think it looks better this way)

I also changed the look / size of the elements in TripEntry to make it more visible.

Graywing13 commented 11 months ago

Looks good, thanks for making the changes!

Some suggestions: image

NLmeng commented 11 months ago

given the width of the entry, i think more spaces between the icons would take too much space. do you think its too cramped? now it truncate only if the icons are there

Graywing13 commented 11 months ago

I see, yeah it'd be too cramped Thx for the chances!

NLmeng commented 11 months ago

update: made the icons slightly smaller plus add a little spacing between:

Screenshot 2023-06-18 at 12 50 45 PM
L0Lmaker commented 11 months ago

As a note for next time, can we tackle issues in seperate PRs if possible? hard to know which changes are related to which in a large PR

NLmeng commented 11 months ago

it was in a separate PR

Graywing13 commented 10 months ago

Those icons look good!