search

cpsgroup / sarapis

A RESTful, proxied, read-only Solr interface
http://sarapis.herokuapp.com
MIT License
1 stars 2 forks source link

distinguish between rootpath and valid subpaths fix #14 #15

Open MartinLichtblau opened 9 years ago

MartinLichtblau commented 9 years ago

distinguish between rootpath and valid subpaths fix #14

vyo commented 9 years ago

Hmm, looks solid. You may merge if you want to. Coverage looks good, too:

No global variable leaks detected Coverage: 86.07% (50/359)

Issue specific comments are in #14.

vyo commented 9 years ago

Just as an aside, leave a blank line after your first commit line - that way only the first line shows up as a sort of headline, makes it easer on the eyes. Perhaps we should agree on some uniform commit style? Yours is really close to mine, I'd just like to have something uniform.

vyo commented 9 years ago

Hmm, would you mind changing rootpath to basepath? Minor, but root makes me think of something more fundamental than what we're specifying here.

MartinLichtblau commented 9 years ago

Yeah agree, that was the first name I gave it. Don't know why I changed it. Will do a PR tomorrow.

MartinLichtblau commented 9 years ago
vyo commented 9 years ago

Would be nice. Take a look at how I mocked the solr client, might help. I'd suggest mocking the solr server and creating at least a positive and a negative test. Not sure if we should mock or test the proxy, too. Suggestions @MartinLichtblau?

On Tue, 7 Jul 2015 23:33 MartinLichtblau notifications@github.com wrote:

— Reply to this email directly or view it on GitHub https://github.com/cpsgroup/sarapis/pull/15#issuecomment-119349059.