search

cpsievert / pitchRx

Tools for scraping MLB Gameday data and Visualizing PITCHf/x
http://cpsievert.github.io/pitchRx/
Other
124 stars 33 forks source link

Problem with scrape example v1 #12

Closed pssguy closed 10 years ago

pssguy commented 10 years ago

Hi. Just trying out example in v1.0

data(gids, package="pitchRx") twins11 <- gids[grepl("min", gids) & grepl("2011", gids)] head(twins11) dat <- scrape(gids=twins11)

Error in XML2Obs(inning.files, as.equiv = FALSE, url.map = FALSE) : unused argument (url.map = FALSE) In addition: Warning message: In makeUrls(start = start, end = end) : Can't 'infer' game urls without start/end date.

dat <- scrape(start="2011-02-27", end="2011-09-28", game.ids=twins11)

helps with the date warning but not with error

cpsievert commented 10 years ago

Thanks for trying out the new version!

I think this will be fixed if you install_github('XML2R', 'cpsievert').

cpsievert commented 10 years ago

Nevermind. This is a legitimate error. Give me a few minutes.

cpsievert commented 10 years ago

Ah, the gids option should be game.ids. Try this:

dat <- scrape(game.ids=twins11)
pssguy commented 10 years ago

Thanks Carson Implemented the changes and downloaded some data Looks good