search

cpsievert / pitchRx

Tools for scraping MLB Gameday data and Visualizing PITCHf/x
http://cpsievert.github.io/pitchRx/
Other
124 stars 33 forks source link

2020 GameDay Issues #69

Closed james-ingold closed 4 years ago

james-ingold commented 4 years ago

It looks like MLB removed the root directory for game days such as: https://gd2.mlb.com/components/game/mlb/year_2020/month_02/day_20/

which returns a 404 now. So updating gids in gids.R doesn't work since it tries to pull the gid from there.

The gameday_link property is also no longer in the mlb files, replaced by just an id with slashes in the format. before: gid_2019_04_19_sfnmlb_pitmlb_1 now: 2020/02/26/slnmlb-houmlb-1. The master branch has updateGids using epg.xml but that has never worked for me: scoreboards <- paste0(makeUrls(start=last.date, end=end, gids=""), "/epg.xml") I still use miniscoreboard.xml

I went down the path of updating the gid format until I ran into the first issue of the root being gone. I'll probably try to use miniscoreboard.xml to get the ids for updateGids but just wanted to document the issues since this library is still used by repositories like https://github.com/BillPetti/baseballr/

james-ingold commented 4 years ago

Added https://github.com/cpsievert/pitchRx/pull/70 to fix the issues with GameDay changes