search

cptactionhank / docker-atlassian-jira-software

Atlassian JIRA Software wrapped in a Docker image
https://cptactionhank.github.io/docker-atlassian-jira-software
MIT License
267 stars 165 forks source link

Dockerfile, docker-entrypoint.sh not sync with those from docker-atlassian-jira image #43

Open jdespatis opened 6 years ago

jdespatis commented 6 years ago

Hello

I've noticed several differences between the 2 images:

But they should share a lot of files (nearly all, only the lira package name changes I think)

The most important difference I've seen is in docker-atlassian-jira-software: those precious lines are missing in docker-entrypoint.sh :

  if [ "${X_PROXY_SCHEME}" = "https" ]; then
    xmlstarlet ed --inplace --pf --ps --insert '//Connector[@port="8080"]' --type "attr" --name "secure" --value "true" "${JIRA_INSTALL}/conf/server.xml"
    xmlstarlet ed --inplace --pf --ps --update '//Connector[@port="8080"]/@redirectPort' --value "${X_PROXY_PORT}" "${JIRA_INSTALL}/conf/server.xml"
  fi

Also, small stuff, docker-atlassian-jira-software uses 5.1.38 MySQL connector but docker-atlassian-jira uses a more recent one (5.1.45)

Could you have a look at those differences please ? ;)

Thanks a lot for your work !