search

cptactionhank / docker-netatalk

Docker container running Netatalk
https://hub.docker.com/r/cptactionhank/netatalk/
MIT License
134 stars 75 forks source link

Refactoring #13

Open solidnerd opened 7 years ago

solidnerd commented 7 years ago

Hey @cptactionhank ,

thanks for your work on this awesome image. I tried it out and it works directly out of the box. I did some refactoring to the Dockerfile this resulted in a smaller image size because the problem of your current Dockerfile is that you are trying to remove something for an another layer and this doesn't work. The netatalk image is your builded image from your current Dockerfile from master. I did some refactorings and now we got only 217.9 MB on my refactored image.

REPOSITORY               TAG                 IMAGE ID            CREATED             SIZE
netatalk-new             latest              2fca29ab7490        33 minutes ago      217.9 MB
netatalk                 latest              25253d84d2e5        2 hours ago         506.3 MB

WDYT ?

AGresvig commented 7 years ago

Nice work! Bump..

solidnerd commented 7 years ago

Thanks :)

utdrmac commented 4 years ago

Can't you get this even smaller by using multi-stage build and just copy the resulting compiled binary to a new image?