search

cptactionhank / docker-netatalk

Docker container running Netatalk
https://hub.docker.com/r/cptactionhank/netatalk/
MIT License
134 stars 75 forks source link

Switched to Alpine, used multistage Dockerfile, added docker-compose.yml #19

Closed unxmaal closed 6 years ago

unxmaal commented 6 years ago

Switching from Alpine, and using a multistage Dockerfile, dropped the container image size from 500mb to 98MB (32MB compressed).

The docker-compose.yml lets users start up by running "docker-compose up", instead of full docker syntax on the CLI.

cptactionhank commented 6 years ago

Very cool and I have been wanting to use builder image for this, but haven't found the time for this. Only concern i have is by using scratch is that it is not possible for account management with netatalk then like PAM? I use PAM/LDAP myself with my image but it would stop working here.

I'll prioritize checking up on your contributions.

Thank you.

unxmaal commented 6 years ago

Closing this for now. After further testing I found a few issues, and fixed them in another commit.

I'll issue another PR shortly.

Using scratch shouldn't affect account management or anything; as you're copying / to / as root, you'd have to subsequently ensure ownership is set properly on anything not owned by root.