search

cptaffe / plan9front

Automatically exported from code.google.com/p/plan9front
0 stars 0 forks source link

hjfs problems when NPROC > 1 #154

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
To reproduce:

Install hjfs on an mp system. Do things (sysupdate; cd /sys/src && mk install; 
etc.). Files become corrupt.

This is not observed on single cpu systems.

Original issue reported on code.google.com by stanley....@gmail.com on 30 Oct 2012 at 3:36

GoogleCodeExporter commented 9 years ago 
found a missing BDELWRI mark in newentry() with some debug code
(not commited) checking clean buffers for modification in putbuf().

got tons of:

hjfs: putbuf cleancrc mismatch, dev /tmp/test.hjfs, block 3241, type dentry, op 
0, getbuf caller 0x6648, putbuf caller 0x678

commited fix in r53664686c2ca

Original comment by cinap_le...@felloff.net on 15 Nov 2012 at 9:26

GoogleCodeExporter commented 9 years ago 
rebuild the kernel on the fixed hjfs with NPROC=4 and compared
the resulting bootfs.paq in my /boot/bootfs.paq, there was no
corruption. can anyone verify this please?

Original comment by cinap_le...@felloff.net on 15 Nov 2012 at 9:40

GoogleCodeExporter commented 9 years ago 
newentry() could allocate dentry that still had
loc pointing to it. the following commit fixes
the NPROC build problems for me: r6467d5bdfc43

please rebuild and verify.

Original comment by cinap_le...@felloff.net on 16 Nov 2012 at 1:46

GoogleCodeExporter commented 9 years ago

Original comment by cinap_le...@felloff.net on 16 Nov 2012 at 2:28