search

cpuheater / pytorch_examples

Some example scripts in pytorch
26 stars 11 forks source link

forward doesn't use it's first argument #4

Closed oraoto closed 6 years ago

oraoto commented 6 years ago

https://github.com/cpuheater/pytorch_examples/blob/b046ea92dc22cc07e5acaa77db55491b38497a48/elman_rnn/Elman_RNN.py#L30-L34

It doesn't use the x argument, but relies on input which is not in the scope of definiation. It's kind of confusing.

cpuheater commented 6 years ago

Yes, this should be input not x, I've renamed it. Thanks !