search

cpunion / react-actioncable-provider

MIT License
154 stars 60 forks source link

React Deprecation Warnings #28

Open hashwin opened 5 years ago

hashwin commented 5 years ago

Started getting a couple of deprecation warnings related to this library with a recent version of React:

Warning: componentWillMount has been renamed, and is not recommended for use. See https://fb.me/react-async-component-lifecycle-hooks for details.

* Move code with side effects to componentDidMount, and set initial state in the constructor.
* Rename componentWillMount to UNSAFE_componentWillMount to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: ActionCableProvider
Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-async-component-lifecycle-hooks for details.

* Move data fetching code or side effects to componentDidUpdate.
* If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state
* Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: ActionCableProvider
JackHowa commented 5 years ago

Updated this @hashwin. Waiting on approval for my pr #29 @cpunion

fabiobarboza7 commented 4 years ago

still having this issue :/

fabiobarboza7 commented 4 years ago

I rewrote for new sintax but I dnd tested: Hope help on it :)

https://gist.github.com/fabiobarboza7/7954170aa0b539a5c8591759ec200107