Closed DohanKim closed 7 months ago
also changed other supervisors to use start_link/3 to attach the name properly
fixing the test failure
there was also a bug setting WalEx.Destinations.Supervisor name
reading :app_name
key instead of :name
Very much appreciated @DohanKim
@DohanKim I just created a new release: https://github.com/cpursley/walex/releases/tag/v3.8.0
Also, does this finally resolve https://github.com/cpursley/walex/issues/38 or are you still experiencing issues?
I think it would, but as I can't reproduce the problem on dev or test environment, I have deployed the PR on my prod server and watching if it's okay. I can say it's resolved whenever a temporary DB connection problem happens and WalEx recovers the connection successfully.
Okay, feel free to close the issue whenever you feel confident that it's resolved :)
(This PR is stacked with the previous one)
The current implementation of WalEx.Config.Registry
makes the supervisor process can’t be found with
GenServer.whereis
as WalEx.Supervisor is not implementing Registry behaviortest:
produces the error
So I changed the WalEx.Config.Registry to use
like other modules
also,
doesn’t properly register the process name (it is using start_link/2) We can check this with the test case above.
So I changed to use start_link/3
With this change, each Supervisor is starting with the name attached and also foundable with its name