cpyarger / obs-midi

Use MIDI devices to trigger events in OBS and vice versa
https://obs-midi.org
GNU General Public License v2.0
168 stars 20 forks source link

Improving Triggering Hotkey functionality #117

Closed lorado closed 3 years ago

lorado commented 3 years ago

Some summary outstanding points:

lorado commented 3 years ago

I updated code and made changes discussed on discord. Sorry, that I removed your QMaps, but using pointer in MidiHook is a better place in my opinion, to store hotkey related data, as they belongs directly to the hook. And it turned out, it works well with obs_hotkey_t directly

lorado commented 3 years ago

So, I did revert my functions using OBS hotkey instances, and used your code with QMap. This solution indeed needs a little bit less code.

lorado commented 3 years ago

most of the changes within this PR is actually clang-format output...