cpyarger / obs-midi

Use MIDI devices to trigger events in OBS and vice versa
https://obs-midi.org
GNU General Public License v2.0
168 stars 20 forks source link

OBS crash when mapping a fader to Do Transition (by mistake) and typo in "OBS MIDI Settings" #134

Open datlaunchystark opened 3 years ago

datlaunchystark commented 3 years ago

Platform

Operating system and version: Windows 10 OBS Studio version: OBS 26.1.1

Expected Behavior

Work without crashing or display a warning message that this could cause an OBS crash.

Current Behavior

Would work but certain mappings cause an OBS crash and I found a typo in the Settings window under the 'configure' tab. "Do not turn this on iif you want the value to be used in the action" 2021-05-15 13-23-27.txt Crash 2021-05-15 13-27-18.txt

Steps to Reproduce

  1. Map fader for Action "Do Transition"
  2. "Preview Scene"
  3. "Current Transition"
  4. Move fader and OBS crash.

Additional information

The crashes are usually random but appears to happen when the fader is moved rapidly. Controller is Roland VM-3100 connected to a Focusrite Scarlett 18i8 via MIDI cables.

cpyarger commented 2 years ago

Right now there are no locks in place when actions are happening. occasionally when too many calls happen too fast obs has issues. Personally I haven't experienced it with do transition. But I also do not use faders for transition triggers. I have experienced it rarely with set volume. but only when I was whipping multiple faders extremely fast. This is probably due to transitions taking a longer period of time to execute.

pgScorpio commented 2 years ago

I also encountered several crashes when assigning faders. Especially when, accidentally, multiple faders are assigned to the same source.

2021-12-13 21-03-52.txt 2021-12-13 21-05-16.txt 2021-12-13 21-11-01.txt 2021-12-13 21-12-53.txt 2021-12-14 19-16-36.txt 2021-12-13 19-29-44.txt 2021-12-13 19-35-14.txt 2021-12-13 19-36-57.txt 2021-12-13 20-05-51.txt 2021-12-13 21-00-33.txt