search

cpyarger / obs-midi

Use MIDI devices to trigger events in OBS and vice versa
https://obs-midi.org
GNU General Public License v2.0
168 stars 20 forks source link

Crash while using obs-midi #85

Closed Wilxx closed 3 years ago

Wilxx commented 3 years ago

Platform

MacBook Pro 15" (2012) (I know you don't get to test the MacOS but I'm reporting it to help you better understand the crashes). Operating system and version: MacOS 10.15.7 OBS Studio version: 26.1.2 ## Expected Behavior I get a crash randomly after a few minutes of using obs-midi. This can me at a random time and usually within a few minutes of mapping something or poking around the mapping interface. I'm not sure if it is connected to the memory leaks that you've described previously. ## Current Behavior OBS quits, gives me a crash report and restarts. The "Show crash report" option in OBS is not opening anything but the logs are. ## Steps to Reproduce
  1. Open OBS and map some buttons in obs-midi.
  2. There will be a time where the app will quit.

Additional information

I am using a Pioneer DJ SP-1 MIDI controller with obs-midi. [2021-02-28 15-58-15.txt](https://github.com/cpyarger/obs-midi/files/6057203/2021-02-28.15-58-15.txt)
cpyarger commented 3 years ago

What version of obs-midi are you running?

Wilxx commented 3 years ago

Hi

Sorry, I should have included that. I am running obs-midi-0c9ed43-macOS.pkg which was updated recently.

Wilxx commented 3 years ago

After checking, it seems obs-midi ALPHA 2 975d363 has a MacOS fix in it so I can give that a go and report back.

Wilxx commented 3 years ago

OBS crash.txt

cpyarger commented 3 years ago

is another application using the midi device? it looks like the error is terminating with uncaught exception of type rtmidi::driver_error: MidiInCore::initialize: error creating OS-X MIDI client object (-50). I can look into it but I am not sure whats the actual problem is. I will check with the rtmidi17 people about this error and see what i find.

Wilxx commented 3 years ago

Fantastic. I was only using OBS at the time with nothing else. I will see if I can work anything out.

cpyarger commented 3 years ago

I have added a catch for the exception that is being thrown, and am building a new release it will be version 506315b and should be out in <10 minutes you can view the progress of the release build here https://github.com/cpyarger/obs-midi/actions/runs/608294081

cpyarger commented 3 years ago

The new release is out https://github.com/cpyarger/obs-midi/releases/latest If you could test it out and let me know how it goes it would be appreciated

Wilxx commented 3 years ago

Hi

I tried the new version and it ran a lot longer before it crashed OBS. I will keep testing though as we seem to be getting somewhere. Hope these help.

2021-02-28 18-43-34.txt

OBS crash 2.txt

cpyarger commented 3 years ago

That looks like a crash in the browser source to me, I don't see any crashes on obs-midi's side.

Wilxx commented 3 years ago

Great news. No other crashes yet. I run a browser source with an overlay that pulls data from the Now Playing in my DJ application (Serato DJ). maybe it was that.

A very small issue with scroll bars/lists. Want me to open a fresh bug report for that?

cpyarger commented 3 years ago

Yes please