search

cqfn / aibolit

Static Analyzer for Java Code with Machine Learning in Mind
https://pypi.org/project/aibolit/
51 stars 17 forks source link

Correct NCSS metric comment and count try keyword. #559

Closed aravij closed 4 years ago

lyriccoder commented 4 years ago

is there a test case when we do not have try statement? we should also consider case when we do not count it.

aravij commented 4 years ago

is there a test case when we do not have try statement? we should also consider case when we do not count it.

Yes we have them, for example here https://github.com/cqfn/aibolit/blob/master/test/metrics/ncss/ChainedIfElse.java

acheshkov commented 4 years ago

@rultor merge

rultor commented 4 years ago

@rultor merge

@acheshkov OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 4 years ago

@rultor merge

@acheshkov Done! FYI, the full log is here (took me 17min)