search

cqfn / jpeek

Hosted and command-line calculator of cohesion metrics for Java code
https://i.jpeek.org
MIT License
209 stars 81 forks source link

Optimize layer transformation in App #438

Open HDouss opened 4 years ago

HDouss commented 4 years ago

The analysis process (analyze method in App class) is building a chain of xsl layer files. The skeleton transformation by these layers is done for every xsl report, to be given as input for that report.:

new XslReport(
    chain.transform(skeleton), xsl,
    new ReportData("...", this.params)
)

chain.transform is called as many times as we have reports. We could do this transformation once and for all and give the result as input to the reports.

This will make this process faster by doing this only once.

0crat commented 4 years ago

@paulodamaso/z please, pay attention to this issue

HDouss commented 4 years ago

@paulodamaso ping

HDouss commented 4 years ago

@paulodamaso ping

paulodamaso commented 4 years ago

@HDouss I think that it will be easier to do this after https://github.com/yegor256/jpeek/issues/461

HDouss commented 4 years ago

@paulodamaso I don't really think it is related, here it is only about chain.transform(skeleton) that is repeated for every XslReport. But anyway, do you agree it has to be done?