search

cqfn / jpeek

Hosted and command-line calculator of cohesion metrics for Java code
https://i.jpeek.org
MIT License
209 stars 81 forks source link

#445 - Extracted a new class and modified another to make it reusable. #463

Closed vzurauskas closed 4 years ago

vzurauskas commented 4 years ago

PR for https://github.com/yegor256/jpeek/issues/445

Extracted a new class. Also noticed a possibility to modify another so it could be reused. That solved the issue of a disabled test which I re-enabled and removed the corresponding todo.

0crat commented 4 years ago

This pull request #463 is assigned to @vatavuk/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job

Vatavuk commented 4 years ago

@0crat refuse

0crat commented 4 years ago

@0crat refuse (here)

@Vatavuk The user @vatavuk/z resigned from #463, please stop working. Reason for job resignation: Order was cancelled

0crat commented 4 years ago

This pull request #463 is assigned to @fanifieiev/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job

fanifieiev commented 4 years ago

@vzurauskas ping

0crat commented 4 years ago

@fanifieiev/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

vzurauskas commented 4 years ago

@fanifieiev Done.

paulodamaso commented 4 years ago

@rultor merge

rultor commented 4 years ago

@rultor merge

@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 4 years ago

@rultor merge

@paulodamaso Done! FYI, the full log is here (took me 14min)

0crat commented 4 years ago

@sereshqua/z please review this job completed by @fanifieiev/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

sereshqua commented 4 years ago

@0crat quality good

sereshqua commented 4 years ago

@0crat quality good

sereshqua commented 4 years ago

@0crat quality good